Skip to content

refactor(dart/transform): Avoid using package:code_transformers - #5931

Closed
kegluneq wants to merge 1 commit into
angular:masterfrom
kegluneq:code_transformers
Closed

kegluneq wants to merge 1 commit into
angular:masterfrom
kegluneq:code_transformers

Conversation

@kegluneq

Copy link
Copy Markdown

/cc @kevmoo

Replace uses of package:code_transformers, which is only used to
convert from uri to AssetId, with calls to the utility methods in
src/transform/common/url_resolver.dart.

@kegluneq kegluneq added comp: dart-transformer refactoring Issue that involves refactoring or code-cleanup labels Dec 16, 2015
@kegluneq kegluneq assigned vsavkin and unassigned yjbanov Jan 4, 2016
@kegluneq kegluneq added the action: review The PR is still awaiting reviews from at least one requested reviewer label Jan 4, 2016
Replace uses of `package:code_transformers`, which is only used to
convert from uri to `AssetId`, with calls to the utility methods in
`src/transform/common/url_resolver.dart`.
@vsavkin vsavkin added pr_state: LGTM and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jan 5, 2016
@vsavkin vsavkin assigned kegluneq and unassigned vsavkin Jan 5, 2016
@kegluneq kegluneq added the action: merge The PR is ready for merge by the caretaker label Jan 5, 2016
@kegluneq kegluneq assigned alxhub and rkirov and unassigned kegluneq and alxhub Jan 5, 2016
@mary-poppins

Copy link
Copy Markdown

Merging PR #5931 on behalf of @jeffbcross to branch presubmit-jeffbcross-pr-5931.

@jeffbcross jeffbcross assigned jeffbcross and unassigned rkirov Jan 13, 2016
@mhevery mhevery closed this in c1c54ed Jan 13, 2016
@kegluneq
kegluneq deleted the code_transformers branch January 14, 2016 21:51
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker cla: yes refactoring Issue that involves refactoring or code-cleanup

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants