Conversation
7a17065 to
c51b511
Compare
|
What was the issue related to this PR ? Did you get what was the root cause of the failure there ? (was it because the fixes to custom expression were not merged ?) Otherwise LGTM - please make travis happy by clanging the PR. |
c51b511 to
64670df
Compare
|
This PR is not fixing any issues. I wrote these tests trying to reproduce #5550, but it turns out that the issue is not in the expression parser or quoted expressions. This PR adds tests that were missing, and these tests also prove that conditional operators work as expected, even after the introduction of quoted expressions. |
|
LGTM |
|
Merging PR #5647 on behalf of @jelbourn to branch presubmit-jelbourn-pr-5647. |
|
Merging PR #5647 on behalf of @jelbourn to branch presubmit-jelbourn-pr-5647. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Bindings and text interpolations were not testing conditional expressions