Skip to content

chore(parser): add tests for conditional expressions - #5647

Closed
yjbanov wants to merge 1 commit into
angular:masterfrom
yjbanov:test-conditionals
Closed

yjbanov wants to merge 1 commit into
angular:masterfrom
yjbanov:test-conditionals

Conversation

@yjbanov

@yjbanov yjbanov commented Dec 6, 2015

Copy link
Copy Markdown
Contributor

Bindings and text interpolations were not testing conditional expressions

@vicb

vicb commented Dec 6, 2015

Copy link
Copy Markdown
Contributor

What was the issue related to this PR ? Did you get what was the root cause of the failure there ? (was it because the fixes to custom expression were not merged ?)

Otherwise LGTM - please make travis happy by clanging the PR.

@vicb vicb added pr_state: LGTM action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Dec 6, 2015
@yjbanov

yjbanov commented Dec 6, 2015

Copy link
Copy Markdown
Contributor Author

This PR is not fixing any issues. I wrote these tests trying to reproduce #5550, but it turns out that the issue is not in the expression parser or quoted expressions. This PR adds tests that were missing, and these tests also prove that conditional operators work as expected, even after the introduction of quoted expressions.

@vicb

vicb commented Dec 6, 2015

Copy link
Copy Markdown
Contributor

LGTM

@vicb vicb added action: merge The PR is ready for merge by the caretaker and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Dec 6, 2015
@mary-poppins

Copy link
Copy Markdown

Merging PR #5647 on behalf of @jelbourn to branch presubmit-jelbourn-pr-5647.

@mary-poppins

Copy link
Copy Markdown

Merging PR #5647 on behalf of @jelbourn to branch presubmit-jelbourn-pr-5647.

@yjbanov yjbanov closed this in 2d313c4 Dec 7, 2015
robwormald pushed a commit to robwormald/angular that referenced this pull request Dec 7, 2015
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker cla: yes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants