Skip to content

docs(router): Updated documentation for router generate method - #5399

Closed
brandonroberts wants to merge 1 commit into
angular:masterfrom
brandonroberts:router-docs-generate
Closed

brandonroberts wants to merge 1 commit into
angular:masterfrom
brandonroberts:router-docs-generate

Conversation

@brandonroberts

Copy link
Copy Markdown
Contributor

The documentation needed an update as it no longer generates a URL.

@IgorMinar IgorMinar added pr_state: LGTM action: merge The PR is ready for merge by the caretaker labels Dec 2, 2015
@IgorMinar IgorMinar added this to the beta.0 milestone Dec 2, 2015
@jelbourn jelbourn added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews and removed action: merge The PR is ready for merge by the caretaker labels Dec 2, 2015
@jelbourn

jelbourn commented Dec 2, 2015

Copy link
Copy Markdown
Contributor

@brandonroberts could you rebase this change?

@brandonroberts

Copy link
Copy Markdown
Contributor Author

@jelbourn Sure. Its rebased

@brandonroberts

Copy link
Copy Markdown
Contributor Author

@jelbourn I rebased again. Build keeps failing somewhere else

@brandonroberts

Copy link
Copy Markdown
Contributor Author

@jelbourn this branch has been rebased and is passing now

@jelbourn jelbourn added action: merge The PR is ready for merge by the caretaker zomg_admin: do merge and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Dec 7, 2015
@mary-poppins

Copy link
Copy Markdown

Merging PR #5399 on behalf of @jelbourn to branch presubmit-jelbourn-pr-5399.

@mary-poppins

Copy link
Copy Markdown

Merging PR #5399 on behalf of @jelbourn to branch presubmit-jelbourn-pr-5399.

@mary-poppins

Copy link
Copy Markdown

Merging PR #5399 on behalf of @jelbourn to branch presubmit-jelbourn-pr-5399.

@mhevery mhevery closed this in 7f0925e Dec 8, 2015
@brandonroberts
brandonroberts deleted the router-docs-generate branch March 4, 2016 14:57
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker cla: yes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants