Skip to content

Should only fire output property once even if both in [outputs] and decorated w/ @Output #4798

Description

@wardbell

Consider this component:

@Component({
  selector: 'hero-detail',
  inputs: ['hero'],
  outputs: ['deleted'],
  template: `
    <div>
      <b>Hero Detail: {{hero?.fullName}}</b>
      <button (click)="onDelete()">Delete</button>
    </div>
  `
})
class HeroDetailComponent {

  @Input()
  hero: Hero;

  @Output()
  deleted = new EventEmitter();

  onDelete() {
    this.deleted.next(this.hero);
  }
}

Now we bind to it:

<hero-detail [hero]="currentHero" (deleted)="onDeleted($event)"></hero-detail>

When the user clicks the Delete button inside <hero-detail>, the parent's onDeleted method is called twice.

Remove either the [outputs] array or the @Output decoration and the parent's method is called only once.

The number of parent method calls increase by one for each additional @Output decoration.

I maintain that any number of mentions as an output > 1 should still mean a single call to the parent method.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions