Skip to content

Angular 4.x regression with embedded view handling #15352

Description

@pkozlowski-opensource

I'm submitting a ... (check one with "x")

[x] bug report => search github for a similar issue or PR before submitting

Minimal reproduction of the problem with instructions

This was discovered when switching ng-bootstrap to Angular 4 rc.5. Here is a plunker that works with the latest 2.3.x but fails when switching to Angular 4 rc.5:

http://plnkr.co/edit/Ha2UMEOc3pT2jUpg1Mjf?p=preview

Steps to reproduce:

  • hover over stars and mouseleave - see that the care comes back to the initial value
  • switch to 4.0.0-rc.5 in the config.js and repeat the scenario - see that with 4.0.0-rc.5 rating doesn't come back to the initial version on mouseleave

You can see the code for the rating directive here: https://github.com/ng-bootstrap/ng-bootstrap/blob/master/src/rating/rating.ts

I'm working on a reduced reproduction scenario but wanted to open an issue ASAP as an "early warning". Currently my suspicion is that sth goes wrong when creating embedded views (or more precisely - refreshing them when context changes). I will provide a smaller reproduce as soon as I can narrow it down.

  • Angular version: 2.0.X

4.0.0-rc.5

  • Browser:

all

  • Language:

TypeScript

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

area: coreIssues related to the framework runtimeregressionIndicates than the issue relates to something that worked in a previous version

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions