Add support for List<Enum> arguments in typesafe navigation - #725
Closed
WonderCsabo wants to merge 1 commit into
Closed
WonderCsabo wants to merge 1 commit into
WonderCsabo wants to merge 1 commit into
Conversation
WonderCsabo
requested review from
claraf3,
ianhanniballake and
jbw0033
as code owners
November 8, 2024 15:10
WonderCsabo
force-pushed
the
typesafe-navigation-arg-enum-list
branch
3 times, most recently
from
November 11, 2024 09:00
eb06a5b to
04b4d0b
Compare
Member
|
Hi, thanks for the PR! Can you please also add tests in RouteDecoderTest.kt? It's basically the opposite equivalent of RouteFilledTest. |
Test: ./gradlew navigation:navigation-common:test Test: ./gradlew navigation:navigation-common:cC Test: ./gradlew navigation:navigation-runtime:cC Bug: 375559962
WonderCsabo
force-pushed
the
typesafe-navigation-arg-enum-list
branch
from
November 13, 2024 15:48
04b4d0b to
79289f5
Compare
Contributor
Author
|
Sure, i added the tests there. |
ianhanniballake
approved these changes
Nov 19, 2024
Member
|
Thanks so much for fixing this! |
Contributor
Author
|
@ianhanniballake this fix was released in 2.8.5 and 2.9.0-alpha04, but it is not listed in the release notes. Can you add there, please? |
Member
|
We've added a note to the release notes - thanks again! In the future, note that you can add a |
MatkovIvan
pushed a commit
to JetBrains/compose-multiplatform-core
that referenced
this pull request
Jul 10, 2025
## Proposed Changes Add support for List<Enum> arguments in typesafe navigation ## Testing Test: ./gradlew navigation:navigation-common:test Test: ./gradlew navigation:navigation-common:cC Test: ./gradlew navigation:navigation-runtime:cC ## Issues Fixed Fixes: 375559962 This is an imported pull request from androidx#725. Resolves #725 Github-Pr-Head-Sha: 79289f5 GitOrigin-RevId: 5d12e8b (cherry picked from https://android-review.googlesource.com/q/commit:061287da098c4249bbe0b3a10add04feb9bdf5ae) (cherry picked from https://android-review.googlesource.com/q/commit:fa9581cf9b203f4b8c2cae0e89485ef5ad26acff) Merged-In: Ie67dc9665634751da06fad21c93e9475627e7e62 Change-Id: Ie67dc9665634751da06fad21c93e9475627e7e62
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Add support for List arguments in typesafe navigation
Testing
Test: ./gradlew navigation:navigation-common:test
Test: ./gradlew navigation:navigation-common:cC
Test: ./gradlew navigation:navigation-runtime:cC
Issues Fixed
Fixes: 375559962