Conversation
dlam
approved these changes
Jun 1, 2023
harryzz
pushed a commit
to harryzz/compose-multiplatform-core
that referenced
this pull request
Jul 28, 2026
`kotlinx.coroutines.test.runTest` returns a `kotlinx.coroutines.test.TestResult`. Per [its documentation](https://kotlinlang.org/api/kotlinx.coroutines/kotlinx-coroutines-test/kotlinx.coroutines.test/-test-result/), JVM and native just type alias to Unit, but when targeting JS it returns a `Promise`. This explicit return type of `Unit` is therefore incorrect when targeting JS. Test: ./gradlew test connectedCheck Bug: 270612487 This is an imported pull request from androidx#554. Resolves JetBrains#554 Github-Pr-Head-Sha: ed0a00b GitOrigin-RevId: 155638a Change-Id: I3333e47c9b8fee3e9a3cfc98171f5abc6e400301
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
kotlinx.coroutines.test.runTestreturns akotlinx.coroutines.test.TestResult. Per its documentation, JVM and native just type alias to Unit, but when targeting JS it returns aPromise. This explicit return type ofUnitis therefore incorrect when targeting JS.Test: ./gradlew test connectedCheck
Bug: 270612487