Conversation
a1558b0 to
222d549
Compare
222d549 to
59a572d
Compare
| * @throws NullPointerException if [actual] or [other] is `null`. | ||
| */ | ||
| fun isAtLeast(other: T?) { | ||
| if (actual == null || other == null) { |
There was a problem hiding this comment.
Let's use the existing requireNonNull function?
There was a problem hiding this comment.
Can do! The implementation was mostly a copy-paste of the isLessThan function above. It could perhaps be simplified there too (in a separate PR).
There was a problem hiding this comment.
@arkivanov Replacing this line with requireNotNull would mean an IllegalArgumentException would be thrown instead of a NullPointerException. This diverges from Truth, as their isAtLeast function also throws a NullPointerException. Was the original suggestion to also change the throwable type?
There was a problem hiding this comment.
I meant our internal function, see
There was a problem hiding this comment.
Oops, my bad! You had linked it in the first message — I completely overlooked it.
Changed in 20d36a6.
To migrate the tests in `paging-common` from Truth to Kruth, `isAtLeast` needs to be added to Kruth: https://github.com/androidx/androidx/blob/60fbea9df29f287c669f7ff69f908f398158379a/paging/paging-common/src/test/kotlin/androidx/paging/FlowExtTest.kt#L289-L290 Test: ./gradlew test connectedCheck Bug: 270612487 This is an imported pull request from androidx#519. Resolves JetBrains#519 Github-Pr-Head-Sha: 20d36a6 GitOrigin-RevId: fd39ef3 Change-Id: I0ec6bb35ff172a03f43d660615066285d17433c1
To migrate the tests in
paging-commonfrom Truth to Kruth,isAtLeastneeds to be added to Kruth:androidx/paging/paging-common/src/test/kotlin/androidx/paging/FlowExtTest.kt
Lines 289 to 290 in 72a6b2e
Test: ./gradlew test connectedCheck
Bug: 270612487