Skip to content

Fix dangling javadoc - #43

Closed
zactestaccount wants to merge 1 commit into
androidx:androidx-master-devfrom
zactestaccount:patch-1
Closed

zactestaccount wants to merge 1 commit into
androidx:androidx-master-devfrom
zactestaccount:patch-1

Conversation

@zactestaccount

@zactestaccount zactestaccount commented Jul 24, 2020

Copy link
Copy Markdown
Contributor

Hi it's Zac from a test account!

Test: It compiles without martians invading

Hi it's Zac from a test account!
@zactestaccount

Copy link
Copy Markdown
Contributor Author

CC @dlam

@googlebot

Copy link
Copy Markdown
Collaborator

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@googlebot

Copy link
Copy Markdown
Collaborator

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@liutikas
liutikas requested a review from tikurahul July 24, 2020 00:20
@tikurahul

tikurahul commented Jul 24, 2020

Copy link
Copy Markdown
Collaborator

@zactestaccount You will need a Test stanza in the pull request body.

Something like Test: N/A.

@zactestaccount

Copy link
Copy Markdown
Contributor Author

Updated the body, is that enough to re-kick?

@dlam dlam added cla: yes and removed cla: no labels Jul 24, 2020
@googlebot

Copy link
Copy Markdown
Collaborator

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

1 similar comment
@googlebot

Copy link
Copy Markdown
Collaborator

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

@dlam
dlam removed the request for review from tikurahul July 24, 2020 02:29
@tikurahul

Copy link
Copy Markdown
Collaborator

@zactestaccount

Copy link
Copy Markdown
Contributor Author

image

@tikurahul

Copy link
Copy Markdown
Collaborator

@zactestaccount your build was successful ! 🛩️

@zactestaccount
zactestaccount deleted the patch-1 branch July 24, 2020 04:15
harryzz pushed a commit to harryzz/compose-multiplatform-core that referenced this pull request Jul 28, 2026
Hi it's Zac from a test account!

Test: It compiles without martians invading

This is an imported pull request from androidx#43.

Resolves JetBrains#43
Github-Pr-Head-Sha: faecf8d
GitOrigin-RevId: 35b3253
Change-Id: Ib9cfe803ba74aa046ca0c5c95916685cb918259a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants