[Lifecycle] [Lint] fixes b/184830263 Lint should use check reference too by kozaxinan · Pull Request #161 · androidx/androidx

kozaxinan · 2021-04-17T11:10:42Z

Proposed Changes

Fix NonNullableMutableLiveDataDetector for different cases. It is possible to only set type reference and omit call's generic argument.
Added check for generic values because default upper bound of generic (if none specified) is Any?. If generic is not specified as <T : Any>, T can be defined null at call site. https://kotlinlang.org/docs/generics.html#upper-bounds

Testing

Test: Run NonNullableMutableLiveDataDetectorTest with new edge cases.
nullLiteralFailMultipleFields : Added type reference
justKotlinObject : Add additional test to prevent ArrayIndexOutOfBoundsException. It is fixed in 428f0ec but not tested. It is reported here with b/184830262
genericParameterDefinition : Generics are assumed as nullable, lint should ignore.

Issues Fixed

Fixes: The bug on b/184830263 being fixed
Fixes: Tests b/184830262

googlebot · 2021-04-17T11:10:46Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

google-cla · 2021-04-17T11:10:47Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

kozaxinan · 2021-04-17T11:11:52Z

@googlebot I signed it!

googlebot · 2021-04-17T11:11:56Z

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

google-cla · 2021-04-17T11:11:56Z

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

kozaxinan · 2021-04-28T14:58:36Z

@jbw0033 Is there anything I can add to this PR?
This lint blocks us to update latest version of lifecycle.

jbw0033 · 2021-05-05T16:20:28Z

From our internal lint:

lifecycle/lifecycle-livedata-core-ktx-lint/src/test/java/androidx/lifecycle/lint/NonNullableMutableLiveDataDetectorTest.kt
#202
Patchset 1
9:08 AM
Lint 🤖
Please remove the trailing whitespace.

#794
Patchset 1
9:08 AM
Lint 🤖
Please remove the trailing whitespace.

kozaxinan · 2021-05-05T17:01:22Z

From our internal lint:

lifecycle/lifecycle-livedata-core-ktx-lint/src/test/java/androidx/lifecycle/lint/NonNullableMutableLiveDataDetectorTest.kt
#202
Patchset 1
9:08 AM
Lint 🤖
Please remove the trailing whitespace.

#794
Patchset 1
9:08 AM
Lint 🤖
Please remove the trailing whitespace.

I deleted whitespaces. When I run ./gradlew buildOnServer some unrelated lints fails, is that expected? (even on main branch)

jbw0033 · 2021-05-06T18:11:01Z

Thank you for the pull request!

…ence too ## Proposed Changes - Fix NonNullableMutableLiveDataDetector for [different cases](https://issuetracker.google.com/issues/184830263). It is possible to only set type reference and omit call's generic argument. - Added check for generic values because default upper bound of generic (if none specified) is Any?. If generic is not specified as `<T : Any>`, `T` can be defined null at call site. https://kotlinlang.org/docs/generics.html#upper-bounds ## Testing Test: Run NonNullableMutableLiveDataDetectorTest with new edge cases. `nullLiteralFailMultipleFields` : Added type reference `justKotlinObject` : Add additional test to prevent ArrayIndexOutOfBoundsException. It is fixed in androidx@1ebd7bc but not tested. It is reported here with [b/184830262](https://issuetracker.google.com/issues/184830262) `genericParameterDefinition` : Generics are assumed as nullable, lint should ignore. ## Issues Fixed Fixes: The bug on [b/184830263](https://issuetracker.google.com/issues/184830263) being fixed Fixes: Tests [b/184830262](https://issuetracker.google.com/issues/184830263) This is an imported pull request from androidx#161. Resolves JetBrains#161 Github-Pr-Head-Sha: e96b4a8 GitOrigin-RevId: eb21c2e Change-Id: Id6cd01e9ec6b79a3f14b569b53d79627c79b9866

googlebot added the cla: no label Apr 17, 2021

googlebot added cla: yes and removed cla: no labels Apr 17, 2021

jbw0033 self-requested a review April 19, 2021 17:25

jbw0033 requested changes May 3, 2021

View reviewed changes

kozaxinan requested a review from jbw0033 May 3, 2021 16:41

fixes b/184830263 Use KtTypeReference for type check

66583d2

kozaxinan force-pushed the 184830263 branch from 5c3c9e7 to 66583d2 Compare May 3, 2021 19:07

jbw0033 requested changes May 3, 2021

View reviewed changes

Comment thread ...ore-ktx-lint/src/test/java/androidx/lifecycle/lint/NonNullableMutableLiveDataDetectorTest.kt Outdated

Check setting generic mutable livedata to null

c0ac33b

kozaxinan requested a review from jbw0033 May 5, 2021 09:02

jbw0033 approved these changes May 5, 2021

View reviewed changes

Delete unnecessary whitespaces in sample code

e96b4a8

copybara-service Bot closed this in 655e08d May 6, 2021

kozaxinan deleted the 184830263 branch May 6, 2021 16:02

Navigation Menu

Uh oh!

[Lifecycle] [Lint] fixes b/184830263 Lint should use check reference too - #161

[Lifecycle] [Lint] fixes b/184830263 Lint should use check reference too#161
kozaxinan wants to merge 3 commits into
androidx:androidx-mainfrom
kozaxinan:184830263

kozaxinan commented Apr 17, 2021 •

edited

Loading

Uh oh!

googlebot commented Apr 17, 2021

Uh oh!

google-cla Bot commented Apr 17, 2021

Uh oh!

kozaxinan commented Apr 17, 2021

Uh oh!

googlebot commented Apr 17, 2021

Uh oh!

google-cla Bot commented Apr 17, 2021

Uh oh!

kozaxinan commented Apr 28, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jbw0033 commented May 5, 2021

Uh oh!

kozaxinan commented May 5, 2021 •

edited

Loading

Uh oh!

jbw0033 commented May 6, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

kozaxinan commented Apr 17, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed Changes

Testing

Issues Fixed

Uh oh!

googlebot commented Apr 17, 2021

What to do if you already signed the CLA

Individual signers

Corporate signers

Uh oh!

google-cla Bot commented Apr 17, 2021

What to do if you already signed the CLA

Individual signers

Corporate signers

Uh oh!

kozaxinan commented Apr 17, 2021

Uh oh!

googlebot commented Apr 17, 2021

Uh oh!

google-cla Bot commented Apr 17, 2021

Uh oh!

kozaxinan commented Apr 28, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jbw0033 commented May 5, 2021

Uh oh!

kozaxinan commented May 5, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jbw0033 commented May 6, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

kozaxinan commented Apr 17, 2021 •

edited

Loading

kozaxinan commented May 5, 2021 •

edited

Loading