Make eslint-compact matcher compatible with Stylelint - #98
Merged
Merged
Conversation
ViniciusFXavier
approved these changes
Apr 7, 2020
commented
Apr 10, 2020
|
I really want this update! 🙏 |
commented
Jan 20, 2021
|
any interest in updating PR to target main instead of master? |
commented
Jan 20, 2021
Author
|
@bryanmacfarlane Done 👌 |
ghost
self-requested a review
August 15, 2022 08:36
commented
Nov 21, 2022
|
commented
Feb 29, 2024
|
Friendly ping 🏓 |
v-priyagupta108
approved these changes
Mar 21, 2025
v-priya-kinthali
approved these changes
Mar 21, 2025
aparnajyothi-y
approved these changes
Mar 21, 2025
szepeviktor
approved these changes
Mar 21, 2025
v-HarithaVattikuti
approved these changes
Mar 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stylelint has a
compactformatter that is (nearly) compatible with ESLint one's.It outputs lowercase severity strings though, so
eslint-compactmatcher's RegExp is not triggered.This PR changes the matcher to also match lowercase severity strings.
Alternatively, the matcher could be duplicated as
stylelint-compactand both RegExps could target exact lowercase/uppercase severities.Example check run containing Stylelint output: https://github.com/OpenLightingProject/open-fixture-library/pull/1163/checks?check_run_id=365592295