Update UserMediaRequestIdentifier and ScrollingNodeID to ObjectIdentifier - #34878
Merged
webkit-commit-queue merged 1 commit intoOct 9, 2024
Merged
webkit-commit-queue merged 1 commit into
webkit-commit-queue merged 1 commit into
Conversation
Collaborator
|
EWS run on previous version of this PR (hash 3b94d58) Details |
cdumez
marked this pull request as ready for review
October 9, 2024 14:37
cdumez
requested review from
achristensen07,
darinadler,
geoffreygaren,
rniwa and
szewai
October 9, 2024 14:37
darinadler
approved these changes
Oct 9, 2024
pvollan
reviewed
Oct 9, 2024
Contributor
There was a problem hiding this comment.
Do we need a check for request.userMediaID() before this?
Contributor
Author
There was a problem hiding this comment.
I can add one but the previous code was already assuming this couldn't be an invalid identifier (since sending an invalid identifier over IPC would have led to crashes).
cdumez
force-pushed
the
281102_ScrollingNodeID_ObjectIdentifier
branch
from
October 9, 2024 14:53
3b94d58 to
2c72bca
Compare
Collaborator
|
EWS run on current version of this PR (hash 2c72bca) Details |
…fier https://bugs.webkit.org/show_bug.cgi?id=281102 Reviewed by Per Arne Vollan and Darin Adler. * Source/WebCore/page/UserMediaRequestIdentifier.h: * Source/WebCore/page/scrolling/ScrollingNodeID.h: * Source/WebCore/page/scrolling/ScrollingStateTree.cpp: (WebCore::ScrollingStateTree::insertNode): (WebCore::ScrollingStateTree::unparentNode): (WebCore::ScrollingStateTree::unparentChildrenAndDestroyNode): (WebCore::ScrollingStateTree::detachAndDestroySubtree): (WebCore::ScrollingStateTree::isValid const): * Source/WebCore/page/scrolling/ScrollingStateTree.h: * Source/WebCore/page/scrolling/ScrollingTree.cpp: (WebCore::ScrollingTree::setUserScrollInProgressForNode): (WebCore::ScrollingTree::setNodeScrollSnapInProgress): (WebCore::ScrollingTree::isScrollAnimationInProgressForNode): (WebCore::ScrollingTree::setScrollAnimationInProgressForNode): * Source/WebCore/page/scrolling/ScrollingTree.h: * Source/WebCore/rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::scrollableAreaForScrollingNodeID const): * Source/WebCore/rendering/RenderLayerCompositor.h: * Source/WebKit/Shared/ProcessQualified.serialization.in: * Source/WebKit/Shared/RemoteLayerTree/RemoteScrollingUIState.h: * Source/WebKit/Shared/WTFArgumentCoders.serialization.in: * Source/WebKit/UIProcess/API/Cocoa/WKWebViewTesting.mm: (-[WKWebView _scrollbarStateForScrollingNodeID:processID:isVertical:]): * Source/WebKit/UIProcess/API/ios/WKWebViewTestingIOS.mm: (-[WKWebView _scrollbarState:processID:isVertical:]): * Source/WebKit/UIProcess/RemoteLayerTree/RemoteScrollingCoordinatorProxy.cpp: (WebKit::RemoteScrollingCoordinatorProxy::deferWheelEventTestCompletionForReason): (WebKit::RemoteScrollingCoordinatorProxy::removeWheelEventTestCompletionDeferralForReason): * Source/WebKit/UIProcess/RemoteLayerTree/RemoteScrollingCoordinatorProxy.h: * Source/WebKit/UIProcess/RemoteLayerTree/mac/RemoteLayerTreeEventDispatcher.h: * Source/WebKit/UIProcess/UserMediaPermissionRequestManagerProxy.cpp: (WebKit::UserMediaPermissionRequestManagerProxy::denyRequest): (WebKit::UserMediaPermissionRequestManagerProxy::grantRequest): (WebKit::UserMediaPermissionRequestManagerProxy::finishGrantingRequest): (WebKit::UserMediaPermissionRequestManagerProxy::processUserMediaPermissionRequest): (WebKit::UserMediaPermissionRequestManagerProxy::processUserMediaPermissionInvalidRequest): (WebKit::UserMediaPermissionRequestManagerProxy::processUserMediaPermissionValidRequest): (WebKit::UserMediaPermissionRequestManagerProxy::checkUserMediaPermissionForSpeechRecognition): * Source/WebKit/UIProcess/UserMediaPermissionRequestProxy.cpp: (WebKit::UserMediaPermissionRequestProxy::create): (WebKit::UserMediaPermissionRequestProxy::UserMediaPermissionRequestProxy): * Source/WebKit/UIProcess/UserMediaPermissionRequestProxy.h: (WebKit::UserMediaPermissionRequestProxy::create): (WebKit::UserMediaPermissionRequestProxy::userMediaID const): * Source/WebKit/UIProcess/WebPageProxy.h: * Source/WebKit/UIProcess/mac/UserMediaPermissionRequestProxyMac.h: * Source/WebKit/UIProcess/mac/UserMediaPermissionRequestProxyMac.mm: (WebKit::UserMediaPermissionRequestProxy::create): (WebKit::UserMediaPermissionRequestProxyMac::UserMediaPermissionRequestProxyMac): Canonical link: https://commits.webkit.org/284897@main
webkit-commit-queue
force-pushed
the
281102_ScrollingNodeID_ObjectIdentifier
branch
from
October 9, 2024 16:20
2c72bca to
3c4a097
Compare
Collaborator
|
Committed 284897@main (3c4a097): https://commits.webkit.org/284897@main Reviewed commits have been landed. Closing PR #34878 and removing active labels. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
3c4a097
2c72bca
🧪 wpe-wk2🧪 ios-wk2🧪 api-mac🧪 api-wpe🧪 gtk-wk2