Skip to content

Bring up macOS Sequoia queues on EWS - #34853

Merged
webkit-commit-queue merged 1 commit into
WebKit:mainfrom
martadarbinyan:eng/Bring-up-macOS-Sequoia-queues-on-EWS
Oct 21, 2024
Merged

webkit-commit-queue merged 1 commit into
WebKit:mainfrom
martadarbinyan:eng/Bring-up-macOS-Sequoia-queues-on-EWS

Conversation

@martadarbinyan

@martadarbinyan martadarbinyan commented Oct 8, 2024

Copy link
Copy Markdown
Contributor

@martadarbinyan martadarbinyan self-assigned this Oct 8, 2024
@martadarbinyan martadarbinyan added New Bugs Unclassified bugs are placed in this component until the correct component can be determined. merge-queue Applied to send a pull request to merge-queue labels Oct 8, 2024
@martadarbinyan martadarbinyan removed the merge-queue Applied to send a pull request to merge-queue label Oct 8, 2024
@ryanhaddad ryanhaddad added the skip-ews Applied to prevent a change from being run on EWS label Oct 8, 2024

@ryanhaddad ryanhaddad left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@ryanhaddad

Copy link
Copy Markdown
Contributor

Looks good to me.

That said, the post-commit equivalent looks like it could use some gardening before we deploy this: https://build.webkit.org/#/builders/1226

@martadarbinyan

Copy link
Copy Markdown
Contributor Author

Looks good to me.

That said, the post-commit equivalent looks like it could use some gardening before we deploy this: https://build.webkit.org/#/builders/1226

Looking now at failing cases.

@martadarbinyan martadarbinyan added merge-queue Applied to send a pull request to merge-queue unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing and removed merge-queue Applied to send a pull request to merge-queue labels Oct 21, 2024
@webkit-commit-queue
webkit-commit-queue force-pushed the eng/Bring-up-macOS-Sequoia-queues-on-EWS branch 2 times, most recently from c998ee6 to bef0443 Compare October 21, 2024 17:21
@martadarbinyan martadarbinyan removed unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing skip-ews Applied to prevent a change from being run on EWS labels Oct 21, 2024
@martadarbinyan
martadarbinyan force-pushed the eng/Bring-up-macOS-Sequoia-queues-on-EWS branch from bef0443 to 2cd16e7 Compare October 21, 2024 18:03
@martadarbinyan martadarbinyan added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Oct 21, 2024
@webkit-commit-queue
webkit-commit-queue force-pushed the eng/Bring-up-macOS-Sequoia-queues-on-EWS branch from 2cd16e7 to 8e71f30 Compare October 21, 2024 18:08
https://bugs.webkit.org/show_bug.cgi?id=281072
rdar://137523857

Reviewed by Ryan Haddad and Jonathan Bedard.

We would like to support macOS Sequoia in EWS. This config change is a part of the migration.

* Tools/CISupport/ews-build/config.json:
* Tools/CISupport/ews-build/factories_unittest.py:
(TestExpectedBuildSteps):

Canonical link: https://commits.webkit.org/285522@main
@webkit-commit-queue
webkit-commit-queue force-pushed the eng/Bring-up-macOS-Sequoia-queues-on-EWS branch from 8e71f30 to d1d8238 Compare October 21, 2024 18:09
@webkit-commit-queue

Copy link
Copy Markdown
Collaborator

Committed 285522@main (d1d8238): https://commits.webkit.org/285522@main

Reviewed commits have been landed. Closing PR #34853 and removing active labels.

@webkit-commit-queue
webkit-commit-queue merged commit d1d8238 into WebKit:main Oct 21, 2024
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

New Bugs Unclassified bugs are placed in this component until the correct component can be determined.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants