Skip to content

Commit b31199b

Browse files
author
Filip Pizlo
committed
Never include *Inlines.h files in interface headers, and never include *Inlines.h when you could include Operations.h instead
https://bugs.webkit.org/show_bug.cgi?id=128505 Reviewed by Mark Hahnenberg and Oliver Hunt. * API/JSContextRef.cpp: * assembler/LinkBuffer.cpp: * bytecode/ArrayProfile.cpp: * bytecode/BytecodeBasicBlock.cpp: * bytecode/BytecodeLivenessAnalysisInlines.h: * bytecode/CallLinkInfo.cpp: * bytecode/CodeBlock.cpp: * bytecode/CodeBlock.h: * bytecode/CodeBlockJettisoningWatchpoint.cpp: * bytecode/ExecutionCounter.cpp: * bytecode/MethodOfGettingAValueProfile.cpp: * bytecode/PreciseJumpTargets.cpp: * bytecode/ProfiledCodeBlockJettisoningWatchpoint.cpp: * bytecode/SamplingTool.cpp: * bytecode/SpecialPointer.cpp: * bytecode/StructureStubClearingWatchpoint.cpp: * debugger/DebuggerCallFrame.cpp: * dfg/DFGAbstractHeap.cpp: * dfg/DFGAbstractValue.cpp: * dfg/DFGArgumentsSimplificationPhase.cpp: * dfg/DFGArithMode.cpp: * dfg/DFGArrayMode.cpp: * dfg/DFGAtTailAbstractState.cpp: * dfg/DFGAvailability.cpp: * dfg/DFGBackwardsPropagationPhase.cpp: * dfg/DFGBasicBlock.cpp: * dfg/DFGBinarySwitch.cpp: * dfg/DFGBlockInsertionSet.cpp: * dfg/DFGByteCodeParser.cpp: * dfg/DFGCFAPhase.cpp: * dfg/DFGCFGSimplificationPhase.cpp: * dfg/DFGCPSRethreadingPhase.cpp: * dfg/DFGCSEPhase.cpp: * dfg/DFGCapabilities.cpp: * dfg/DFGClobberSet.cpp: * dfg/DFGClobberize.cpp: * dfg/DFGCommon.cpp: * dfg/DFGCommonData.cpp: * dfg/DFGCompilationKey.cpp: * dfg/DFGCompilationMode.cpp: * dfg/DFGConstantFoldingPhase.cpp: * dfg/DFGCriticalEdgeBreakingPhase.cpp: * dfg/DFGDCEPhase.cpp: * dfg/DFGDesiredIdentifiers.cpp: * dfg/DFGDesiredStructureChains.cpp: * dfg/DFGDesiredTransitions.cpp: * dfg/DFGDesiredWatchpoints.cpp: * dfg/DFGDisassembler.cpp: * dfg/DFGDisassembler.h: * dfg/DFGDominators.cpp: * dfg/DFGEdge.cpp: * dfg/DFGFailedFinalizer.cpp: * dfg/DFGFinalizer.cpp: * dfg/DFGFixupPhase.cpp: * dfg/DFGFlushFormat.cpp: * dfg/DFGFlushLivenessAnalysisPhase.cpp: * dfg/DFGFlushedAt.cpp: * dfg/DFGGraph.cpp: * dfg/DFGInPlaceAbstractState.cpp: * dfg/DFGInvalidationPointInjectionPhase.cpp: * dfg/DFGJITCode.cpp: * dfg/DFGJITCompiler.cpp: * dfg/DFGJITCompiler.h: * dfg/DFGJITFinalizer.cpp: * dfg/DFGJumpReplacement.cpp: * dfg/DFGLICMPhase.cpp: * dfg/DFGLazyJSValue.cpp: * dfg/DFGLivenessAnalysisPhase.cpp: * dfg/DFGLongLivedState.cpp: * dfg/DFGLoopPreHeaderCreationPhase.cpp: * dfg/DFGMinifiedNode.cpp: * dfg/DFGNaturalLoops.cpp: * dfg/DFGNode.cpp: * dfg/DFGNodeFlags.cpp: * dfg/DFGOSRAvailabilityAnalysisPhase.cpp: * dfg/DFGOSREntry.cpp: * dfg/DFGOSREntrypointCreationPhase.cpp: * dfg/DFGOSRExit.cpp: * dfg/DFGOSRExitBase.cpp: * dfg/DFGOSRExitCompiler.cpp: * dfg/DFGOSRExitCompiler32_64.cpp: * dfg/DFGOSRExitCompiler64.cpp: * dfg/DFGOSRExitCompilerCommon.cpp: * dfg/DFGOSRExitJumpPlaceholder.cpp: * dfg/DFGOSRExitPreparation.cpp: * dfg/DFGOperations.cpp: * dfg/DFGOperations.h: * dfg/DFGPhase.cpp: * dfg/DFGPlan.cpp: * dfg/DFGPredictionInjectionPhase.cpp: * dfg/DFGPredictionPropagationPhase.cpp: * dfg/DFGResurrectionForValidationPhase.cpp: * dfg/DFGSSAConversionPhase.cpp: * dfg/DFGSSALoweringPhase.cpp: * dfg/DFGSpeculativeJIT.cpp: * dfg/DFGSpeculativeJIT32_64.cpp: * dfg/DFGSpeculativeJIT64.cpp: * dfg/DFGStackLayoutPhase.cpp: * dfg/DFGStoreBarrierElisionPhase.cpp: * dfg/DFGStrengthReductionPhase.cpp: * dfg/DFGThunks.cpp: * dfg/DFGTierUpCheckInjectionPhase.cpp: * dfg/DFGToFTLDeferredCompilationCallback.cpp: * dfg/DFGToFTLForOSREntryDeferredCompilationCallback.cpp: * dfg/DFGTypeCheckHoistingPhase.cpp: * dfg/DFGUnificationPhase.cpp: * dfg/DFGUseKind.cpp: * dfg/DFGValidate.cpp: * dfg/DFGValueSource.cpp: * dfg/DFGVariableAccessDataDump.cpp: * dfg/DFGVariableEvent.cpp: * dfg/DFGVariableEventStream.cpp: * dfg/DFGVirtualRegisterAllocationPhase.cpp: * dfg/DFGWatchpointCollectionPhase.cpp: * dfg/DFGWorklist.cpp: * disassembler/Disassembler.cpp: * ftl/FTLLink.cpp: * ftl/FTLOSRExitCompiler.cpp: * ftl/FTLSlowPathCall.cpp: * ftl/FTLThunks.cpp: (JSC::FTL::slowPathCallThunkGenerator): * heap/BlockAllocator.cpp: * heap/CodeBlockSet.cpp: * heap/ConservativeRoots.cpp: * heap/DeferGC.cpp: * heap/GCThread.cpp: * heap/GCThreadSharedData.cpp: * heap/HeapTimer.cpp: * heap/IncrementalSweeper.cpp: * heap/JITStubRoutineSet.cpp: * heap/MachineStackMarker.cpp: * heap/MarkStack.cpp: * heap/MarkedAllocator.cpp: * heap/MarkedSpace.cpp: * heap/SuperRegion.cpp: * heap/Weak.cpp: * heap/WeakHandleOwner.cpp: * heap/WeakSet.cpp: * heap/WriteBarrierBuffer.cpp: * heap/WriteBarrierSupport.cpp: * inspector/ScriptCallStackFactory.cpp: * interpreter/AbstractPC.cpp: * interpreter/JSStack.cpp: * interpreter/ProtoCallFrame.cpp: * interpreter/VMInspector.cpp: * jit/ArityCheckFailReturnThunks.cpp: * jit/AssemblyHelpers.cpp: * jit/ExecutableAllocator.cpp: * jit/ExecutableAllocatorFixedVMPool.cpp: * jit/GCAwareJITStubRoutine.cpp: * jit/HostCallReturnValue.cpp: * jit/JITDisassembler.cpp: * jit/JITDisassembler.h: * jit/JITExceptions.cpp: * jit/JITInlines.h: * jit/JITOperations.cpp: * jit/JITOperationsMSVC64.cpp: * jit/JITStubRoutine.cpp: * jit/JITStubs.cpp: * jit/JITToDFGDeferredCompilationCallback.cpp: * jit/RegisterPreservationWrapperGenerator.cpp: * jit/RegisterSet.cpp: * jit/Repatch.cpp: * jit/TempRegisterSet.cpp: * jsc.cpp: * parser/Lexer.cpp: * parser/Parser.cpp: * parser/ParserArena.cpp: * parser/SourceCode.cpp: * parser/SourceProvider.cpp: * parser/SourceProviderCache.cpp: * profiler/ProfileGenerator.cpp: * runtime/Arguments.cpp: * runtime/ArgumentsIteratorPrototype.cpp: * runtime/CommonSlowPathsExceptions.cpp: * runtime/JSArgumentsIterator.cpp: * runtime/JSFunction.cpp: * runtime/JSGlobalObjectFunctions.cpp: * runtime/ObjectConstructor.cpp: * runtime/Operations.h: * runtime/VM.cpp: Canonical link: https://commits.webkit.org/146528@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@163760 268f45cc-cd09-0410-ab3c-d52691b4dbfc
1 parent e4990a6 commit b31199b

181 files changed

Lines changed: 556 additions & 186 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

Source/JavaScriptCore/API/JSContextRef.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,6 @@
2929

3030
#include "APICast.h"
3131
#include "CallFrame.h"
32-
#include "CallFrameInlines.h"
3332
#include "InitializeThreading.h"
3433
#include "JSCallbackObject.h"
3534
#include "JSClassRef.h"

Source/JavaScriptCore/ChangeLog

Lines changed: 189 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,192 @@
1+
2014-02-09 Filip Pizlo <[email protected]>
2+
3+
Never include *Inlines.h files in interface headers, and never include *Inlines.h when you could include Operations.h instead
4+
https://bugs.webkit.org/show_bug.cgi?id=128505
5+
6+
Reviewed by Mark Hahnenberg and Oliver Hunt.
7+
8+
* API/JSContextRef.cpp:
9+
* assembler/LinkBuffer.cpp:
10+
* bytecode/ArrayProfile.cpp:
11+
* bytecode/BytecodeBasicBlock.cpp:
12+
* bytecode/BytecodeLivenessAnalysisInlines.h:
13+
* bytecode/CallLinkInfo.cpp:
14+
* bytecode/CodeBlock.cpp:
15+
* bytecode/CodeBlock.h:
16+
* bytecode/CodeBlockJettisoningWatchpoint.cpp:
17+
* bytecode/ExecutionCounter.cpp:
18+
* bytecode/MethodOfGettingAValueProfile.cpp:
19+
* bytecode/PreciseJumpTargets.cpp:
20+
* bytecode/ProfiledCodeBlockJettisoningWatchpoint.cpp:
21+
* bytecode/SamplingTool.cpp:
22+
* bytecode/SpecialPointer.cpp:
23+
* bytecode/StructureStubClearingWatchpoint.cpp:
24+
* debugger/DebuggerCallFrame.cpp:
25+
* dfg/DFGAbstractHeap.cpp:
26+
* dfg/DFGAbstractValue.cpp:
27+
* dfg/DFGArgumentsSimplificationPhase.cpp:
28+
* dfg/DFGArithMode.cpp:
29+
* dfg/DFGArrayMode.cpp:
30+
* dfg/DFGAtTailAbstractState.cpp:
31+
* dfg/DFGAvailability.cpp:
32+
* dfg/DFGBackwardsPropagationPhase.cpp:
33+
* dfg/DFGBasicBlock.cpp:
34+
* dfg/DFGBinarySwitch.cpp:
35+
* dfg/DFGBlockInsertionSet.cpp:
36+
* dfg/DFGByteCodeParser.cpp:
37+
* dfg/DFGCFAPhase.cpp:
38+
* dfg/DFGCFGSimplificationPhase.cpp:
39+
* dfg/DFGCPSRethreadingPhase.cpp:
40+
* dfg/DFGCSEPhase.cpp:
41+
* dfg/DFGCapabilities.cpp:
42+
* dfg/DFGClobberSet.cpp:
43+
* dfg/DFGClobberize.cpp:
44+
* dfg/DFGCommon.cpp:
45+
* dfg/DFGCommonData.cpp:
46+
* dfg/DFGCompilationKey.cpp:
47+
* dfg/DFGCompilationMode.cpp:
48+
* dfg/DFGConstantFoldingPhase.cpp:
49+
* dfg/DFGCriticalEdgeBreakingPhase.cpp:
50+
* dfg/DFGDCEPhase.cpp:
51+
* dfg/DFGDesiredIdentifiers.cpp:
52+
* dfg/DFGDesiredStructureChains.cpp:
53+
* dfg/DFGDesiredTransitions.cpp:
54+
* dfg/DFGDesiredWatchpoints.cpp:
55+
* dfg/DFGDisassembler.cpp:
56+
* dfg/DFGDisassembler.h:
57+
* dfg/DFGDominators.cpp:
58+
* dfg/DFGEdge.cpp:
59+
* dfg/DFGFailedFinalizer.cpp:
60+
* dfg/DFGFinalizer.cpp:
61+
* dfg/DFGFixupPhase.cpp:
62+
* dfg/DFGFlushFormat.cpp:
63+
* dfg/DFGFlushLivenessAnalysisPhase.cpp:
64+
* dfg/DFGFlushedAt.cpp:
65+
* dfg/DFGGraph.cpp:
66+
* dfg/DFGInPlaceAbstractState.cpp:
67+
* dfg/DFGInvalidationPointInjectionPhase.cpp:
68+
* dfg/DFGJITCode.cpp:
69+
* dfg/DFGJITCompiler.cpp:
70+
* dfg/DFGJITCompiler.h:
71+
* dfg/DFGJITFinalizer.cpp:
72+
* dfg/DFGJumpReplacement.cpp:
73+
* dfg/DFGLICMPhase.cpp:
74+
* dfg/DFGLazyJSValue.cpp:
75+
* dfg/DFGLivenessAnalysisPhase.cpp:
76+
* dfg/DFGLongLivedState.cpp:
77+
* dfg/DFGLoopPreHeaderCreationPhase.cpp:
78+
* dfg/DFGMinifiedNode.cpp:
79+
* dfg/DFGNaturalLoops.cpp:
80+
* dfg/DFGNode.cpp:
81+
* dfg/DFGNodeFlags.cpp:
82+
* dfg/DFGOSRAvailabilityAnalysisPhase.cpp:
83+
* dfg/DFGOSREntry.cpp:
84+
* dfg/DFGOSREntrypointCreationPhase.cpp:
85+
* dfg/DFGOSRExit.cpp:
86+
* dfg/DFGOSRExitBase.cpp:
87+
* dfg/DFGOSRExitCompiler.cpp:
88+
* dfg/DFGOSRExitCompiler32_64.cpp:
89+
* dfg/DFGOSRExitCompiler64.cpp:
90+
* dfg/DFGOSRExitCompilerCommon.cpp:
91+
* dfg/DFGOSRExitJumpPlaceholder.cpp:
92+
* dfg/DFGOSRExitPreparation.cpp:
93+
* dfg/DFGOperations.cpp:
94+
* dfg/DFGOperations.h:
95+
* dfg/DFGPhase.cpp:
96+
* dfg/DFGPlan.cpp:
97+
* dfg/DFGPredictionInjectionPhase.cpp:
98+
* dfg/DFGPredictionPropagationPhase.cpp:
99+
* dfg/DFGResurrectionForValidationPhase.cpp:
100+
* dfg/DFGSSAConversionPhase.cpp:
101+
* dfg/DFGSSALoweringPhase.cpp:
102+
* dfg/DFGSpeculativeJIT.cpp:
103+
* dfg/DFGSpeculativeJIT32_64.cpp:
104+
* dfg/DFGSpeculativeJIT64.cpp:
105+
* dfg/DFGStackLayoutPhase.cpp:
106+
* dfg/DFGStoreBarrierElisionPhase.cpp:
107+
* dfg/DFGStrengthReductionPhase.cpp:
108+
* dfg/DFGThunks.cpp:
109+
* dfg/DFGTierUpCheckInjectionPhase.cpp:
110+
* dfg/DFGToFTLDeferredCompilationCallback.cpp:
111+
* dfg/DFGToFTLForOSREntryDeferredCompilationCallback.cpp:
112+
* dfg/DFGTypeCheckHoistingPhase.cpp:
113+
* dfg/DFGUnificationPhase.cpp:
114+
* dfg/DFGUseKind.cpp:
115+
* dfg/DFGValidate.cpp:
116+
* dfg/DFGValueSource.cpp:
117+
* dfg/DFGVariableAccessDataDump.cpp:
118+
* dfg/DFGVariableEvent.cpp:
119+
* dfg/DFGVariableEventStream.cpp:
120+
* dfg/DFGVirtualRegisterAllocationPhase.cpp:
121+
* dfg/DFGWatchpointCollectionPhase.cpp:
122+
* dfg/DFGWorklist.cpp:
123+
* disassembler/Disassembler.cpp:
124+
* ftl/FTLLink.cpp:
125+
* ftl/FTLOSRExitCompiler.cpp:
126+
* ftl/FTLSlowPathCall.cpp:
127+
* ftl/FTLThunks.cpp:
128+
(JSC::FTL::slowPathCallThunkGenerator):
129+
* heap/BlockAllocator.cpp:
130+
* heap/CodeBlockSet.cpp:
131+
* heap/ConservativeRoots.cpp:
132+
* heap/DeferGC.cpp:
133+
* heap/GCThread.cpp:
134+
* heap/GCThreadSharedData.cpp:
135+
* heap/HeapTimer.cpp:
136+
* heap/IncrementalSweeper.cpp:
137+
* heap/JITStubRoutineSet.cpp:
138+
* heap/MachineStackMarker.cpp:
139+
* heap/MarkStack.cpp:
140+
* heap/MarkedAllocator.cpp:
141+
* heap/MarkedSpace.cpp:
142+
* heap/SuperRegion.cpp:
143+
* heap/Weak.cpp:
144+
* heap/WeakHandleOwner.cpp:
145+
* heap/WeakSet.cpp:
146+
* heap/WriteBarrierBuffer.cpp:
147+
* heap/WriteBarrierSupport.cpp:
148+
* inspector/ScriptCallStackFactory.cpp:
149+
* interpreter/AbstractPC.cpp:
150+
* interpreter/JSStack.cpp:
151+
* interpreter/ProtoCallFrame.cpp:
152+
* interpreter/VMInspector.cpp:
153+
* jit/ArityCheckFailReturnThunks.cpp:
154+
* jit/AssemblyHelpers.cpp:
155+
* jit/ExecutableAllocator.cpp:
156+
* jit/ExecutableAllocatorFixedVMPool.cpp:
157+
* jit/GCAwareJITStubRoutine.cpp:
158+
* jit/HostCallReturnValue.cpp:
159+
* jit/JITDisassembler.cpp:
160+
* jit/JITDisassembler.h:
161+
* jit/JITExceptions.cpp:
162+
* jit/JITInlines.h:
163+
* jit/JITOperations.cpp:
164+
* jit/JITOperationsMSVC64.cpp:
165+
* jit/JITStubRoutine.cpp:
166+
* jit/JITStubs.cpp:
167+
* jit/JITToDFGDeferredCompilationCallback.cpp:
168+
* jit/RegisterPreservationWrapperGenerator.cpp:
169+
* jit/RegisterSet.cpp:
170+
* jit/Repatch.cpp:
171+
* jit/TempRegisterSet.cpp:
172+
* jsc.cpp:
173+
* parser/Lexer.cpp:
174+
* parser/Parser.cpp:
175+
* parser/ParserArena.cpp:
176+
* parser/SourceCode.cpp:
177+
* parser/SourceProvider.cpp:
178+
* parser/SourceProviderCache.cpp:
179+
* profiler/ProfileGenerator.cpp:
180+
* runtime/Arguments.cpp:
181+
* runtime/ArgumentsIteratorPrototype.cpp:
182+
* runtime/CommonSlowPathsExceptions.cpp:
183+
* runtime/JSArgumentsIterator.cpp:
184+
* runtime/JSFunction.cpp:
185+
* runtime/JSGlobalObjectFunctions.cpp:
186+
* runtime/ObjectConstructor.cpp:
187+
* runtime/Operations.h:
188+
* runtime/VM.cpp:
189+
1190
2014-02-09 Filip Pizlo <[email protected]>
2191

3192
Unreviewed, don't mark isHostFunction() inline in the header file because that really confuses EFL.

Source/JavaScriptCore/assembler/LinkBuffer.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@
3030

3131
#include "CodeBlock.h"
3232
#include "JITCode.h"
33+
#include "Operations.h"
3334
#include "Options.h"
3435
#include "VM.h"
3536
#include <wtf/CompilationThread.h>

Source/JavaScriptCore/bytecode/ArrayProfile.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@
2727
#include "ArrayProfile.h"
2828

2929
#include "CodeBlock.h"
30+
#include "Operations.h"
3031
#include <wtf/CommaPrinter.h>
3132
#include <wtf/StringExtras.h>
3233
#include <wtf/StringPrintStream.h>

Source/JavaScriptCore/bytecode/BytecodeBasicBlock.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@
2727
#include "BytecodeBasicBlock.h"
2828

2929
#include "CodeBlock.h"
30+
#include "Operations.h"
3031
#include "PreciseJumpTargets.h"
3132

3233
namespace JSC {

Source/JavaScriptCore/bytecode/BytecodeLivenessAnalysisInlines.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@
2828

2929
#include "BytecodeLivenessAnalysis.h"
3030
#include "CodeBlock.h"
31+
#include "Operations.h"
3132

3233
namespace JSC {
3334

Source/JavaScriptCore/bytecode/CallLinkInfo.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@
2828

2929
#include "DFGOperations.h"
3030
#include "DFGThunks.h"
31+
#include "Operations.h"
3132
#include "RepatchBuffer.h"
3233

3334
#if ENABLE(JIT)

Source/JavaScriptCore/bytecode/CodeBlock.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@
3636
#include "DFGCapabilities.h"
3737
#include "DFGCommon.h"
3838
#include "DFGDriver.h"
39+
#include "DFGJITCode.h"
3940
#include "DFGNode.h"
4041
#include "DFGWorklist.h"
4142
#include "Debugger.h"

Source/JavaScriptCore/bytecode/CodeBlock.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,6 @@
5656
#include "HandlerInfo.h"
5757
#include "ObjectAllocationProfile.h"
5858
#include "Options.h"
59-
#include "Operations.h"
6059
#include "PutPropertySlot.h"
6160
#include "Instruction.h"
6261
#include "JITCode.h"

Source/JavaScriptCore/bytecode/CodeBlockJettisoningWatchpoint.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@
2828

2929
#include "CodeBlock.h"
3030
#include "DFGCommon.h"
31+
#include "Operations.h"
3132

3233
namespace JSC {
3334

0 commit comments

Comments
 (0)