|
| 1 | +2014-02-09 Filip Pizlo < [email protected]> |
| 2 | + |
| 3 | + Never include *Inlines.h files in interface headers, and never include *Inlines.h when you could include Operations.h instead |
| 4 | + https://bugs.webkit.org/show_bug.cgi?id=128505 |
| 5 | + |
| 6 | + Reviewed by Mark Hahnenberg and Oliver Hunt. |
| 7 | + |
| 8 | + * API/JSContextRef.cpp: |
| 9 | + * assembler/LinkBuffer.cpp: |
| 10 | + * bytecode/ArrayProfile.cpp: |
| 11 | + * bytecode/BytecodeBasicBlock.cpp: |
| 12 | + * bytecode/BytecodeLivenessAnalysisInlines.h: |
| 13 | + * bytecode/CallLinkInfo.cpp: |
| 14 | + * bytecode/CodeBlock.cpp: |
| 15 | + * bytecode/CodeBlock.h: |
| 16 | + * bytecode/CodeBlockJettisoningWatchpoint.cpp: |
| 17 | + * bytecode/ExecutionCounter.cpp: |
| 18 | + * bytecode/MethodOfGettingAValueProfile.cpp: |
| 19 | + * bytecode/PreciseJumpTargets.cpp: |
| 20 | + * bytecode/ProfiledCodeBlockJettisoningWatchpoint.cpp: |
| 21 | + * bytecode/SamplingTool.cpp: |
| 22 | + * bytecode/SpecialPointer.cpp: |
| 23 | + * bytecode/StructureStubClearingWatchpoint.cpp: |
| 24 | + * debugger/DebuggerCallFrame.cpp: |
| 25 | + * dfg/DFGAbstractHeap.cpp: |
| 26 | + * dfg/DFGAbstractValue.cpp: |
| 27 | + * dfg/DFGArgumentsSimplificationPhase.cpp: |
| 28 | + * dfg/DFGArithMode.cpp: |
| 29 | + * dfg/DFGArrayMode.cpp: |
| 30 | + * dfg/DFGAtTailAbstractState.cpp: |
| 31 | + * dfg/DFGAvailability.cpp: |
| 32 | + * dfg/DFGBackwardsPropagationPhase.cpp: |
| 33 | + * dfg/DFGBasicBlock.cpp: |
| 34 | + * dfg/DFGBinarySwitch.cpp: |
| 35 | + * dfg/DFGBlockInsertionSet.cpp: |
| 36 | + * dfg/DFGByteCodeParser.cpp: |
| 37 | + * dfg/DFGCFAPhase.cpp: |
| 38 | + * dfg/DFGCFGSimplificationPhase.cpp: |
| 39 | + * dfg/DFGCPSRethreadingPhase.cpp: |
| 40 | + * dfg/DFGCSEPhase.cpp: |
| 41 | + * dfg/DFGCapabilities.cpp: |
| 42 | + * dfg/DFGClobberSet.cpp: |
| 43 | + * dfg/DFGClobberize.cpp: |
| 44 | + * dfg/DFGCommon.cpp: |
| 45 | + * dfg/DFGCommonData.cpp: |
| 46 | + * dfg/DFGCompilationKey.cpp: |
| 47 | + * dfg/DFGCompilationMode.cpp: |
| 48 | + * dfg/DFGConstantFoldingPhase.cpp: |
| 49 | + * dfg/DFGCriticalEdgeBreakingPhase.cpp: |
| 50 | + * dfg/DFGDCEPhase.cpp: |
| 51 | + * dfg/DFGDesiredIdentifiers.cpp: |
| 52 | + * dfg/DFGDesiredStructureChains.cpp: |
| 53 | + * dfg/DFGDesiredTransitions.cpp: |
| 54 | + * dfg/DFGDesiredWatchpoints.cpp: |
| 55 | + * dfg/DFGDisassembler.cpp: |
| 56 | + * dfg/DFGDisassembler.h: |
| 57 | + * dfg/DFGDominators.cpp: |
| 58 | + * dfg/DFGEdge.cpp: |
| 59 | + * dfg/DFGFailedFinalizer.cpp: |
| 60 | + * dfg/DFGFinalizer.cpp: |
| 61 | + * dfg/DFGFixupPhase.cpp: |
| 62 | + * dfg/DFGFlushFormat.cpp: |
| 63 | + * dfg/DFGFlushLivenessAnalysisPhase.cpp: |
| 64 | + * dfg/DFGFlushedAt.cpp: |
| 65 | + * dfg/DFGGraph.cpp: |
| 66 | + * dfg/DFGInPlaceAbstractState.cpp: |
| 67 | + * dfg/DFGInvalidationPointInjectionPhase.cpp: |
| 68 | + * dfg/DFGJITCode.cpp: |
| 69 | + * dfg/DFGJITCompiler.cpp: |
| 70 | + * dfg/DFGJITCompiler.h: |
| 71 | + * dfg/DFGJITFinalizer.cpp: |
| 72 | + * dfg/DFGJumpReplacement.cpp: |
| 73 | + * dfg/DFGLICMPhase.cpp: |
| 74 | + * dfg/DFGLazyJSValue.cpp: |
| 75 | + * dfg/DFGLivenessAnalysisPhase.cpp: |
| 76 | + * dfg/DFGLongLivedState.cpp: |
| 77 | + * dfg/DFGLoopPreHeaderCreationPhase.cpp: |
| 78 | + * dfg/DFGMinifiedNode.cpp: |
| 79 | + * dfg/DFGNaturalLoops.cpp: |
| 80 | + * dfg/DFGNode.cpp: |
| 81 | + * dfg/DFGNodeFlags.cpp: |
| 82 | + * dfg/DFGOSRAvailabilityAnalysisPhase.cpp: |
| 83 | + * dfg/DFGOSREntry.cpp: |
| 84 | + * dfg/DFGOSREntrypointCreationPhase.cpp: |
| 85 | + * dfg/DFGOSRExit.cpp: |
| 86 | + * dfg/DFGOSRExitBase.cpp: |
| 87 | + * dfg/DFGOSRExitCompiler.cpp: |
| 88 | + * dfg/DFGOSRExitCompiler32_64.cpp: |
| 89 | + * dfg/DFGOSRExitCompiler64.cpp: |
| 90 | + * dfg/DFGOSRExitCompilerCommon.cpp: |
| 91 | + * dfg/DFGOSRExitJumpPlaceholder.cpp: |
| 92 | + * dfg/DFGOSRExitPreparation.cpp: |
| 93 | + * dfg/DFGOperations.cpp: |
| 94 | + * dfg/DFGOperations.h: |
| 95 | + * dfg/DFGPhase.cpp: |
| 96 | + * dfg/DFGPlan.cpp: |
| 97 | + * dfg/DFGPredictionInjectionPhase.cpp: |
| 98 | + * dfg/DFGPredictionPropagationPhase.cpp: |
| 99 | + * dfg/DFGResurrectionForValidationPhase.cpp: |
| 100 | + * dfg/DFGSSAConversionPhase.cpp: |
| 101 | + * dfg/DFGSSALoweringPhase.cpp: |
| 102 | + * dfg/DFGSpeculativeJIT.cpp: |
| 103 | + * dfg/DFGSpeculativeJIT32_64.cpp: |
| 104 | + * dfg/DFGSpeculativeJIT64.cpp: |
| 105 | + * dfg/DFGStackLayoutPhase.cpp: |
| 106 | + * dfg/DFGStoreBarrierElisionPhase.cpp: |
| 107 | + * dfg/DFGStrengthReductionPhase.cpp: |
| 108 | + * dfg/DFGThunks.cpp: |
| 109 | + * dfg/DFGTierUpCheckInjectionPhase.cpp: |
| 110 | + * dfg/DFGToFTLDeferredCompilationCallback.cpp: |
| 111 | + * dfg/DFGToFTLForOSREntryDeferredCompilationCallback.cpp: |
| 112 | + * dfg/DFGTypeCheckHoistingPhase.cpp: |
| 113 | + * dfg/DFGUnificationPhase.cpp: |
| 114 | + * dfg/DFGUseKind.cpp: |
| 115 | + * dfg/DFGValidate.cpp: |
| 116 | + * dfg/DFGValueSource.cpp: |
| 117 | + * dfg/DFGVariableAccessDataDump.cpp: |
| 118 | + * dfg/DFGVariableEvent.cpp: |
| 119 | + * dfg/DFGVariableEventStream.cpp: |
| 120 | + * dfg/DFGVirtualRegisterAllocationPhase.cpp: |
| 121 | + * dfg/DFGWatchpointCollectionPhase.cpp: |
| 122 | + * dfg/DFGWorklist.cpp: |
| 123 | + * disassembler/Disassembler.cpp: |
| 124 | + * ftl/FTLLink.cpp: |
| 125 | + * ftl/FTLOSRExitCompiler.cpp: |
| 126 | + * ftl/FTLSlowPathCall.cpp: |
| 127 | + * ftl/FTLThunks.cpp: |
| 128 | + (JSC::FTL::slowPathCallThunkGenerator): |
| 129 | + * heap/BlockAllocator.cpp: |
| 130 | + * heap/CodeBlockSet.cpp: |
| 131 | + * heap/ConservativeRoots.cpp: |
| 132 | + * heap/DeferGC.cpp: |
| 133 | + * heap/GCThread.cpp: |
| 134 | + * heap/GCThreadSharedData.cpp: |
| 135 | + * heap/HeapTimer.cpp: |
| 136 | + * heap/IncrementalSweeper.cpp: |
| 137 | + * heap/JITStubRoutineSet.cpp: |
| 138 | + * heap/MachineStackMarker.cpp: |
| 139 | + * heap/MarkStack.cpp: |
| 140 | + * heap/MarkedAllocator.cpp: |
| 141 | + * heap/MarkedSpace.cpp: |
| 142 | + * heap/SuperRegion.cpp: |
| 143 | + * heap/Weak.cpp: |
| 144 | + * heap/WeakHandleOwner.cpp: |
| 145 | + * heap/WeakSet.cpp: |
| 146 | + * heap/WriteBarrierBuffer.cpp: |
| 147 | + * heap/WriteBarrierSupport.cpp: |
| 148 | + * inspector/ScriptCallStackFactory.cpp: |
| 149 | + * interpreter/AbstractPC.cpp: |
| 150 | + * interpreter/JSStack.cpp: |
| 151 | + * interpreter/ProtoCallFrame.cpp: |
| 152 | + * interpreter/VMInspector.cpp: |
| 153 | + * jit/ArityCheckFailReturnThunks.cpp: |
| 154 | + * jit/AssemblyHelpers.cpp: |
| 155 | + * jit/ExecutableAllocator.cpp: |
| 156 | + * jit/ExecutableAllocatorFixedVMPool.cpp: |
| 157 | + * jit/GCAwareJITStubRoutine.cpp: |
| 158 | + * jit/HostCallReturnValue.cpp: |
| 159 | + * jit/JITDisassembler.cpp: |
| 160 | + * jit/JITDisassembler.h: |
| 161 | + * jit/JITExceptions.cpp: |
| 162 | + * jit/JITInlines.h: |
| 163 | + * jit/JITOperations.cpp: |
| 164 | + * jit/JITOperationsMSVC64.cpp: |
| 165 | + * jit/JITStubRoutine.cpp: |
| 166 | + * jit/JITStubs.cpp: |
| 167 | + * jit/JITToDFGDeferredCompilationCallback.cpp: |
| 168 | + * jit/RegisterPreservationWrapperGenerator.cpp: |
| 169 | + * jit/RegisterSet.cpp: |
| 170 | + * jit/Repatch.cpp: |
| 171 | + * jit/TempRegisterSet.cpp: |
| 172 | + * jsc.cpp: |
| 173 | + * parser/Lexer.cpp: |
| 174 | + * parser/Parser.cpp: |
| 175 | + * parser/ParserArena.cpp: |
| 176 | + * parser/SourceCode.cpp: |
| 177 | + * parser/SourceProvider.cpp: |
| 178 | + * parser/SourceProviderCache.cpp: |
| 179 | + * profiler/ProfileGenerator.cpp: |
| 180 | + * runtime/Arguments.cpp: |
| 181 | + * runtime/ArgumentsIteratorPrototype.cpp: |
| 182 | + * runtime/CommonSlowPathsExceptions.cpp: |
| 183 | + * runtime/JSArgumentsIterator.cpp: |
| 184 | + * runtime/JSFunction.cpp: |
| 185 | + * runtime/JSGlobalObjectFunctions.cpp: |
| 186 | + * runtime/ObjectConstructor.cpp: |
| 187 | + * runtime/Operations.h: |
| 188 | + * runtime/VM.cpp: |
| 189 | + |
1 | 190 | 2014-02-09 Filip Pizlo < [email protected]> |
2 | 191 |
|
3 | 192 | Unreviewed, don't mark isHostFunction() inline in the header file because that really confuses EFL. |
|
0 commit comments