Skip to content

Fix breakpoint removal after debugger exit - #1179

Merged
xusheng6 merged 1 commit into
devfrom
test_1175_breakpoint_removal
Aug 17, 2026
Merged

xusheng6 merged 1 commit into
devfrom
test_1175_breakpoint_removal

Conversation

@xusheng6

@xusheng6 xusheng6 commented Aug 14, 2026

Copy link
Copy Markdown
Member

Avoid backend breakpoint removal after debugger teardown and add regression coverage. Fixes #1175.

A potential follow-up task is identified in #1180. However, this is no proof that COM object liftime is causing any issues (this one and beyond) because we are already using an actor model to serialize the accesses to the adapter

@xusheng6
xusheng6 marked this pull request as ready for review August 14, 2026 20:19
@xusheng6
xusheng6 requested a review from plafosse August 14, 2026 20:20

@fuzyll fuzyll left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

@xusheng6
xusheng6 merged commit c3d5295 into dev Aug 17, 2026
2 checks passed
@xusheng6
xusheng6 deleted the test_1175_breakpoint_removal branch August 17, 2026 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Crash removing a breakpoint via the toolbar (DbgEngAdapter::RemoveBreakpoint)

2 participants