Skip to content

Reverting an undo action brings Binary Ninja to the front #8352

Description

@bdash

Version and Platform (required):

  • Binary Ninja Version: 5.4.10157-dev Ultimate, 5b89dad7
  • OS: macOS 26.5.2
  • CPU Architecture: arm64

Bug Description:
I noticed while looking at #8351 that every failed use of bn_function_prototype_set was causing Binary Ninja to activate and steal focus from my terminal. This appears to be due to ViewFrame::navigate unconditionally calling raise and activateWindow on the window. In this case, the navigation happens as a side-effect of an undo action being reverted.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Impact: MediumIssue is impactful with a bad, or no, workaroundUI: Global AreaIssues with the Global Area

Type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions