Bump minimist from 1.2.5 to 1.2.6 - #3
Closed
dependabot[bot] wants to merge 4 commits into
Closed
dependabot[bot] wants to merge 4 commits into
dependabot[bot] wants to merge 4 commits into
Conversation
Bumps [minimist](https://github.com/substack/minimist) from 1.2.5 to 1.2.6. - [Release notes](https://github.com/substack/minimist/releases) - [Commits](https://github.com/substack/minimist/compare/1.2.5...1.2.6) --- updated-dependencies: - dependency-name: minimist dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
Author
|
Looks like minimist is up-to-date now, so this is no longer needed. |
pull Bot
pushed a commit
that referenced
this pull request
Oct 16, 2025
…lessAggressive` This test is intermittently failing with the following error: [ RUN ] DomainBlockTest.NoInterstitialUnlessAggressive [806484:806484:1015/131900.057034:FATAL:content/public/test/browser_test_utils.cc:1627] Check failed: is_ok(). Can't ExtractString() because the script encountered a problem: a JavaScript error: "RenderFrame deleted." #0 0x652c37727912 base::debug::CollectStackTrace() [../../base/debug/stack_trace_posix.cc:1052:7] #1 0x652c3770f131 base::debug::StackTrace::StackTrace() [../../base/debug/stack_trace.cc:279:20] #2 0x652c376067da logging::LogMessage::Flush() [../../base/logging.cc:705:29] #3 0x652c3760669d logging::LogMessage::~LogMessage() [../../base/logging.cc:694:3] #4 0x652c375ec212 logging::(anonymous namespace)::CheckLogMessage::~CheckLogMessage() [../../base/check.cc:164:3] #5 0x652c375ebefb logging::CheckNoreturnError::~CheckNoreturnError() [../../base/check.cc:321:16] #6 0x652c3ffd799c content::EvalJsResult::ExtractString() [../../content/public/test/browser_test_utils.cc:1627:3] #7 0x652c3ffdb53e content::WaitForRenderFrameReady() [../../content/public/test/browser_test_utils.cc:2300:12] #8 0x652c2db6534a DomainBlockTestBase::NavigateTo() [../../brave/browser/brave_shields/domain_block_page_browsertest.cc:61:5] #9 0x652c2db68e30 DomainBlockTest_NoInterstitialUnlessAggressive_Test::RunTestOnMainThread() [../../brave/browser/brave_shields/domain_block_page_browsertest.cc:359:3] #10 0x652c3ffd2b4e content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() [../../content/public/test/browser_test_base.cc:974:9] #11 0x652c2db7e811 base::OnceCallback<>::Run() [../../base/functional/callback.h:155:12] #12 0x652c328fb0a1 content::BrowserMainRunnerImpl::Run() [../../content/browser/browser_main_runner_impl.cc:150:15] #13 0x652c328f4dd0 content::BrowserMain() [../../content/browser/browser_main.cc:32:28] #14 0x652c34e3c272 content::RunBrowserProcessMain() [../../content/app/content_main_runner_impl.cc:702:10] #15 0x652c34e3ebda content::ContentMainRunnerImpl::RunBrowser() [../../content/app/content_main_runner_impl.cc:1289:10] #16 0x652c34e3e3b4 content::ContentMainRunnerImpl::Run() [../../content/app/content_main_runner_impl.cc:1128:12] #17 0x652c34e3ac6b content::RunContentProcess() [../../content/app/content_main.cc:346:36] #18 0x652c34e3add4 content::ContentMain() [../../content/app/content_main.cc:359:10] #19 0x652c3ffd19a7 content::BrowserTestBase::SetUp() [../../content/public/test/browser_test_base.cc:609:3] #20 0x652c36e01e58 InProcessBrowserTest::SetUp() [../../chrome/test/base/in_process_browser_test.cc:535:20] #21 0x652c2db6a806 DomainBlockTestBase::SetUp() [../../brave/browser/brave_shields/domain_block_page_browsertest.cc:47:25] #22 0x652c35ad79f0 testing::Test::Run() [../../third_party/googletest/src/googletest/src/gtest.cc:5267:3] #23 0x652c35ad8852 testing::TestInfo::Run() [../../third_party/googletest/src/googletest/src/gtest.cc:2892:11] #24 0x652c35ad9467 testing::TestSuite::Run() [../../third_party/googletest/src/googletest/src/gtest.cc:3070:30] #25 0x652c35ae71c7 testing::internal::UnitTestImpl::RunAllTests() [../../third_party/googletest/src/googletest/src/gtest.cc:6062:44] #26 0x652c35ae69af testing::UnitTest::Run() [../../third_party/googletest/src/googletest/src/gtest.cc:5267:3] #27 0x652c3ff5c1ba base::TestSuite::Run() [../../base/test/test_suite.cc:438:16] #28 0x652c36dfffa6 ChromeTestSuiteRunner::RunTestSuite() [../../chrome/test/base/chrome_test_launcher.cc:102:22] #29 0x652c36e002df ChromeTestLauncherDelegate::RunTestSuite() [../../chrome/test/base/chrome_test_launcher.cc:156:19] #30 0x652c3fffdf44 content::LaunchTestsInternal() [../../content/public/test/test_launcher.cc:424:31] #31 0x652c3fffe555 content::LaunchTests() [../../content/public/test/test_launcher.cc:519:10] #32 0x652c36e0058b LaunchChromeTests() [../../chrome/test/base/chrome_test_launcher.cc:357:10] #33 0x652c35cacfc5 main [../../brave/test/base/browser_tests_main.cc:66:10] #34 0x781a84a29d90 (/usr/lib/x86_64-linux-gnu/libc.so.6+0x29d8f) #35 0x781a84a29e40 __libc_start_main #36 0x652c2dafe02a _start There doesn't seem to be an actual need to wait for the render frame in that utility method, so I removed it and verified that all tests pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps minimist from 1.2.5 to 1.2.6.
Commits
7efb22a1.2.6ef88b93security notice for additional prototype pollution issuec2b9819isConstructorOrProto adapted from PRbc8eceetest from prototype pollution PRDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)@dependabot use these labelswill set the current labels as the default for future PRs for this repo and language@dependabot use these reviewerswill set the current reviewers as the default for future PRs for this repo and language@dependabot use these assigneeswill set the current assignees as the default for future PRs for this repo and language@dependabot use this milestonewill set the current milestone as the default for future PRs for this repo and languageYou can disable automated security fix PRs for this repo from the Security Alerts page.