host_env: Don't truncate two byte wchar_t - #8296
Merged
youknowone merged 1 commit intoJul 17, 2026
Merged
Conversation
Casting a u32 to a u16 would truncate the value. It's safer to use Wtf::encode_wide which already handles converting a CodePoint to a u16. I removed vec_into_bytes because it was only used in two places. The function was unsound for T but sound in the way RustPython used it (POD to POD, less strict alignment). AI disclosure: I linted this code with AI. I found this issue by accident while working on another patch in which I introduced a similar mistake. AI caught that mistake, so I linted the original code to cross-check it. I wrote the code myself in both instances. Assisted-by: Codex:gpt-5.4
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughWide-character helpers now support compile-time decoding and platform-dependent null-terminated byte generation. UTF-16 encoding explicitly flattens native-endian code units and appends a wide-character terminator. ChangesWide-character encoding
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
youknowone
approved these changes
Jul 17, 2026
youknowone
left a comment
Member
There was a problem hiding this comment.
good, i didn't think about this before, thanks!
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Casting a u32 to a u16 would truncate the value. It's safer to use
Wtf8::encode_widewhich already handles converting a CodePoint to a u16.I removed
vec_into_bytesbecause it was only used in two places. The function was unsound for T but sound in the way RustPython used it (POD to POD, less strict alignment).AI disclosure: I linted this code with AI. I found this issue by accident while working on another patch in which I introduced a similar mistake. AI caught that mistake, so I linted the original code to cross-check it. I wrote the code myself in both instances.
Assisted-by: Codex:gpt-5.4
Summary
wchar_tbeing truncated fromu32tou16instead of correctly being encoded.Summary by CodeRabbit
Bug Fixes
Refactor