Add comprehensive array and dictionary tests for ConvertTo-Json - #26742
Merged
Dongbo Wang (daxian-dbw) merged 5 commits intoFeb 6, 2026
Merged
Dongbo Wang (daxian-dbw) merged 5 commits into
Dongbo Wang (daxian-dbw) merged 5 commits into
Conversation
6 tasks
Member
|
Yoshifumi (@yotsuda) or Ilya (@iSazonov), can either of you please resolve the conflict? I won't be able to approve and merge the PR if I resolve it. |
Co-Authored-By: Claude Opus 4.5 <[email protected]>
- Use IPAddress instead of integer for depth limit tests to clearly verify ToString() is called when depth is exceeded - Use Unicode escape format for unicode key test - Add array versions of DateTime, Guid, and enum serialization tests - Remove duplicate 'array with hashtable elements' test Co-Authored-By: Claude Opus 4.5 <[email protected]>
- Change IP from 10.0.0.1 to 192.168.1.1 for consistency with previous test - Replace BeLike/Not-BeExactly with BeExactly using actual JSON output Co-Authored-By: Claude Opus 4.5 <[email protected]>
Yoshifumi (yotsuda)
force-pushed
the
add-convertto-json-array-dictionary-tests
branch
from
February 6, 2026 01:18
117c0bc to
78b2ae0
Compare
Contributor
Author
|
Dongbo Wang (@daxian-dbw) Rebased onto master to resolve the conflict. |
6 tasks
Yoshifumi (yotsuda)
marked this pull request as draft
February 6, 2026 12:22
Yoshifumi (yotsuda)
marked this pull request as ready for review
February 6, 2026 13:07
Ilya (iSazonov)
approved these changes
Feb 6, 2026
Dongbo Wang (daxian-dbw)
approved these changes
Feb 6, 2026
Yoshifumi (yotsuda)
deleted the
add-convertto-json-array-dictionary-tests
branch
February 10, 2026 00:09
Justin Grote (JustinGrote)
pushed a commit
to JustinGrote/PowerShell
that referenced
this pull request
Jun 2, 2026
Thatgfsj (Thatgfsj)
pushed a commit
to Thatgfsj-contribs/PowerShell
that referenced
this pull request
Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Add comprehensive array and dictionary tests for
ConvertTo-Json(Phase 2).PR Context
This is a follow-up to #26736. Per Ilya (@iSazonov)'s suggestion in #26639, comprehensive tests are being submitted as separate PRs for each phase.
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerTests Added
The following array and dictionary tests are added to
ConvertTo-Json.Tests.ps1:Total: 48 new tests