Add fn demo command - #8
Merged
Merged
Conversation
Member
|
The binary shouldn't be put into the source repo maybe? |
tpiperatgod
requested changes
Dec 6, 2021
wenchajun
force-pushed
the
demo
branch
2 times, most recently
from
December 13, 2021 02:17
8009d27 to
454b017
Compare
Member
|
It's ready to review now? Please solve the conflict first, thanks @wenchajun |
benjaminhuo
reviewed
Dec 14, 2021
benjaminhuo
reviewed
Dec 14, 2021
benjaminhuo
reviewed
Dec 14, 2021
benjaminhuo
reviewed
Dec 14, 2021
benjaminhuo
reviewed
Dec 14, 2021
benjaminhuo
reviewed
Dec 14, 2021
benjaminhuo
reviewed
Dec 14, 2021
benjaminhuo
reviewed
Dec 14, 2021
benjaminhuo
reviewed
Dec 14, 2021
benjaminhuo
reviewed
Dec 14, 2021
benjaminhuo
reviewed
Dec 14, 2021
benjaminhuo
reviewed
Dec 14, 2021
benjaminhuo
reviewed
Dec 14, 2021
|
|
||
| func init() { | ||
| w = os.Stdout | ||
| availableVersions = []string{"v0.3.1", "v0.4.0", "latest"} |
Member
There was a problem hiding this comment.
Need to figure out a better way instead of hardcoding supported versions
tpiperatgod
requested changes
Dec 15, 2021
wenchajun
force-pushed
the
demo
branch
3 times, most recently
from
December 15, 2021 08:55
4eb8724 to
4ac135e
Compare
Member
|
@wenchajun would you make corresponding changes to the version list similar to #14 ? |
Member
Author
Yes，We had a discussion and I was going to make the demo components independent to get a lower coupling. I will modify this demo architecture and update it. |
wenchajun
force-pushed
the
demo
branch
4 times, most recently
from
December 20, 2021 14:20
f263a45 to
c6fa7ca
Compare
tpiperatgod
requested changes
Dec 21, 2021
wenchajun
force-pushed
the
demo
branch
2 times, most recently
from
December 21, 2021 02:38
699cd36 to
3b3aa01
Compare
tpiperatgod
approved these changes
Dec 21, 2021
benjaminhuo
reviewed
Dec 21, 2021
|
|
||
| cmd.Flags().BoolVar(&i.Verbose, "verbose", false, "Show verbose information.") | ||
| cmd.Flags().BoolVar(&i.RegionCN, "region-cn", false, "For users who have limited access to gcr.io or github.com.") | ||
| cmd.Flags().BoolVar(&i.AutoPrune, "auto-prune", true, "Used to specify the version of OpenFunction to be uninstalled.") |
Member
There was a problem hiding this comment.
"Used to specify the version of OpenFunction to be uninstalled." is not correct for auto-prune
benjaminhuo
reviewed
Dec 21, 2021
|
|
||
| cmd.Flags().BoolVar(&i.Verbose, "verbose", false, "Show verbose information.") | ||
| cmd.Flags().BoolVar(&i.RegionCN, "region-cn", false, "For users who have limited access to gcr.io or github.com.") | ||
| cmd.Flags().BoolVar(&i.AutoPrune, "auto-prune", true, "Automatic cleaning of the current environment.") |
Member
There was a problem hiding this comment.
Automatically clean up the demo environment.
Signed-off-by: chengdehao <[email protected]>
benjaminhuo
approved these changes
Dec 21, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add fn demo command
Signed-off-by: chengdehao [email protected]