Skip to content

remove redundant https:// - #45

Merged
tpiperatgod merged 1 commit into
OpenFunction:mainfrom
James-JLC:main
May 16, 2022
Merged

tpiperatgod merged 1 commit into
OpenFunction:mainfrom
James-JLC:main

Conversation

@James-JLC

Copy link
Copy Markdown
Contributor

the redundant https:// should be removed

@CLAassistant

CLAassistant commented May 16, 2022

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@tpiperatgod

Copy link
Copy Markdown
Member

Thanks, it seems you need to pass the CLA and DCO checks first. 🙂

@tpiperatgod tpiperatgod left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@James-JLC

Copy link
Copy Markdown
Contributor Author

Signed-off-by: jilichao

@benjaminhuo

benjaminhuo commented May 16, 2022

Copy link
Copy Markdown
Member

@jilichao You need to squash and then sign your commits

  • squash the 5 commits into 1:
    git rebase -i squash head~5
    image

https://www.git-tower.com/learn/git/faq/git-squash/

  • re-sign the new commit:
    git commit -s --amend

@benjaminhuo

Copy link
Copy Markdown
Member

The commit has been messed up, maybe you can close this PR.
Fork the repo again and using a new branch to submit this PR
@jilichao

@James-JLC

Copy link
Copy Markdown
Contributor Author

@benjaminhuo I submitted several times due to the internet issue before, and it should be fixed now.

@tpiperatgod
tpiperatgod merged commit 67e3391 into OpenFunction:main May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants