Skip to content

Adjust the flags for "ofn install" and "ofn uninstall". - #39

Merged
benjaminhuo merged 1 commit into
OpenFunction:mainfrom
tpiperatgod:adjust_flags
Apr 8, 2022
Merged

benjaminhuo merged 1 commit into
OpenFunction:mainfrom
tpiperatgod:adjust_flags

Conversation

@tpiperatgod

Copy link
Copy Markdown
Member

for issue #32

  1. use --runtime to specify the runtimes that need to be installed.
  2. display the flags by "users' perspective" and "technical's perspective", and by default do not display "technical's perspective" flags
  3. add install_test.go and uninstall_test.go
  4. add make test

Signed-off-by: laminar [email protected]

@tpiperatgod tpiperatgod linked an issue Apr 6, 2022 that may be closed by this pull request
@benjaminhuo
benjaminhuo requested a review from wanjunlei April 6, 2022 07:00
Comment thread docs/uninstall.md
Comment thread pkg/cmd/subcommand/install.go Outdated
Comment thread docs/uninstall.md
Signed-off-by: laminar <[email protected]>
@benjaminhuo
benjaminhuo merged commit 348368c into OpenFunction:main Apr 8, 2022
@tpiperatgod
tpiperatgod deleted the adjust_flags branch April 8, 2022 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Proposal to adjust cli flags

3 participants