Skip to content

update: change the default version of OpenFunction to the latest stable version - #23

Merged
benjaminhuo merged 2 commits into
OpenFunction:mainfrom
tpiperatgod:main
Jan 3, 2022
Merged

benjaminhuo merged 2 commits into
OpenFunction:mainfrom
tpiperatgod:main

Conversation

@tpiperatgod

Copy link
Copy Markdown
Member
  1. change the default version of OpenFunction to the latest stable version
  2. add the --force option to force the operation
  3. use the spinner instead of the original process display
  4. adjust the function hierarchy to make some functions more generic
  5. update docs

Signed-off-by: laminar <[email protected]>
@tpiperatgod

Copy link
Copy Markdown
Member Author

Untitled

Comment thread README.md Outdated
✓ Ingress - Completed!
✓ OpenFunction - Completed!
🚀 Completed in 4m45.512145978s.
Notice that you are using Knative runtime, you can refer to the following to configure Knative's network layer (Assuming you are using Kourier) and DNS.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you are using Knative runtime => If you are using Knative runtime

you can refer to the following => you can refer to the following instructions

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these tips can be removed...

Comment thread README.md Outdated
✓ OpenFunction - Completed!
🚀 Completed in 4m45.512145978s.
Notice that you are using Knative runtime, you can refer to the following to configure Knative's network layer (Assuming you are using Kourier) and DNS.
Where 1.2.3.4 can be replaced by your node address or loadbalancer address:

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can be => should be

Comment thread README.md Outdated
🚀 Completed in 4m45.512145978s.
Notice that you are using Knative runtime, you can refer to the following to configure Knative's network layer (Assuming you are using Kourier) and DNS.
Where 1.2.3.4 can be replaced by your node address or loadbalancer address:

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Refer to the Fetch the External IP address or CNAME by running the command: section to adjust the 1.2.3.4 desc.

As I can remember, the loadbalancer's IP is assigned automatically, why patching this IP?

Patching a node's IP to this only works for single node scenario?

https://knative.dev/docs/install/serving/install-serving-with-yaml/
image

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, as there are many configuration options for this section, I think the tips can be removed...

Comment thread docs/install.md Outdated
Comment thread docs/uninstall.md Outdated
Comment thread pkg/cmd/util/spinner/spinner.go Outdated
}

// ErrorWithMessage marks spinner as error and update message
func (s *Spinner) ErrorWithMessage(message string, err error) {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can still use Error with different args

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change to this:

// Error marks spinner as error
func (s *Spinner) Error(err error) {
	s.ErrorWithMessage(failed, err)
}

// ErrorWithMessage marks spinner as error and update message
func (s *Spinner) ErrorWithMessage(message string, err error) {
	s.Update(message)
	s.stop(errorStatus)
	if err != nil {
		s.group.err = err
		s.group.errC <- err
	}
}

Comment thread pkg/cmd/util/spinner/spinner.go Outdated
Comment thread pkg/cmd/util/spinner/spinner_group.go Outdated
Comment thread pkg/cmd/util/spinner/spinner_group.go Outdated
Comment thread pkg/cmd/util/spinner/spinner.go Outdated
@tpiperatgod
tpiperatgod force-pushed the main branch 2 times, most recently from 99eff7b to bb7c4c3 Compare January 3, 2022 02:41
Comment thread VERSION
Comment thread README.md Outdated
Comment thread pkg/cmd/subcommand/uninstall.go Outdated
@benjaminhuo
benjaminhuo merged commit 233163b into OpenFunction:main Jan 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace the default OpenFunction version installed with latest stable release Need to add some useful options to improve the efficiency of cli

2 participants