update: change the default version of OpenFunction to the latest stable version - #23
Conversation
Signed-off-by: laminar <[email protected]>
| ✓ Ingress - Completed! | ||
| ✓ OpenFunction - Completed! | ||
| 🚀 Completed in 4m45.512145978s. | ||
| Notice that you are using Knative runtime, you can refer to the following to configure Knative's network layer (Assuming you are using Kourier) and DNS. |
There was a problem hiding this comment.
you are using Knative runtime => If you are using Knative runtime
you can refer to the following => you can refer to the following instructions
There was a problem hiding this comment.
I think these tips can be removed...
| ✓ OpenFunction - Completed! | ||
| 🚀 Completed in 4m45.512145978s. | ||
| Notice that you are using Knative runtime, you can refer to the following to configure Knative's network layer (Assuming you are using Kourier) and DNS. | ||
| Where 1.2.3.4 can be replaced by your node address or loadbalancer address: |
| 🚀 Completed in 4m45.512145978s. | ||
| Notice that you are using Knative runtime, you can refer to the following to configure Knative's network layer (Assuming you are using Kourier) and DNS. | ||
| Where 1.2.3.4 can be replaced by your node address or loadbalancer address: | ||
|
|
There was a problem hiding this comment.
Refer to the Fetch the External IP address or CNAME by running the command: section to adjust the 1.2.3.4 desc.
As I can remember, the loadbalancer's IP is assigned automatically, why patching this IP?
Patching a node's IP to this only works for single node scenario?
https://knative.dev/docs/install/serving/install-serving-with-yaml/

There was a problem hiding this comment.
Yes, as there are many configuration options for this section, I think the tips can be removed...
| } | ||
|
|
||
| // ErrorWithMessage marks spinner as error and update message | ||
| func (s *Spinner) ErrorWithMessage(message string, err error) { |
There was a problem hiding this comment.
Can still use Error with different args
There was a problem hiding this comment.
change to this:
// Error marks spinner as error
func (s *Spinner) Error(err error) {
s.ErrorWithMessage(failed, err)
}
// ErrorWithMessage marks spinner as error and update message
func (s *Spinner) ErrorWithMessage(message string, err error) {
s.Update(message)
s.stop(errorStatus)
if err != nil {
s.group.err = err
s.group.errC <- err
}
}99eff7b to
bb7c4c3
Compare
…le version. Signed-off-by: laminar <[email protected]>

--forceoption to force the operation