Skip to content

chore: oxlint with oxfmt - #6120

Open
NathanWalker wants to merge 1 commit into
mainfrom
feat/oxc
Open

chore: oxlint with oxfmt#6120
NathanWalker wants to merge 1 commit into
mainfrom
feat/oxc

Conversation

@NathanWalker

@NathanWalker NathanWalker commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Swap prettier/eslint with oxfmt/oxlint.

Measured before the conversion, on the full lib/ + test/ source tree: 527 TypeScript files, ~117k lines. Each command ran 5 times after 1 warmup run (Node child process, cold start included), on an Apple M3 Max (16 threads), Node v24.1.0.

Task Tool Mean Min Max Speedup
Format check prettier 3.9.6 --check 2,228 ms 2,199 ms 2,262 ms 1×
Format check oxfmt 0.61.0 --check 239 ms 236 ms 243 ms ~9.3×
Lint ESLint 10.8.0 + typescript-eslint 8.65.0 (recommended) 1,932 ms 1,917 ms 1,956 ms 1×
Lint oxlint 1.76.0 589 ms 583 ms 600 ms ~3.4×

@NathanWalker
NathanWalker requested a review from edusperoni August 3, 2026 02:00
@coderabbitai

coderabbitai Bot commented Aug 3, 2026

Copy link
Copy Markdown

Important

Review skipped

Too many files!

This PR contains 324 files, which is 174 over the limit of 150.

To get a review, narrow the scope:
• coderabbit review --committed # exclude uncommitted changes
• coderabbit review --dir # limit to a subdirectory
• coderabbit review --base # compare against a closer base

Upgrade to a paid plan to raise the limit.

Usage-priced reviews support at most 300 files.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 3a7ca9d1-a366-4747-9718-657a3b3ffe2c

📥 Commits

Reviewing files that changed from the base of the PR and between dfae38d and dae07b7.

⛔ Files ignored due to path filters (1)
  • package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (324)
  • .github/workflows/tests.yml
  • .oxfmtrc.json
  • .oxlintrc.json
  • .prettierrc.json
  • CONTRIBUTING.md
  • lib/android-tools-info.ts
  • lib/base-package-manager.ts
  • lib/bun-package-manager.ts
  • lib/commands/add-platform.ts
  • lib/commands/apple-login.ts
  • lib/commands/appstore-list.ts
  • lib/commands/appstore-upload.ts
  • lib/commands/clean.ts
  • lib/commands/command-base.ts
  • lib/commands/config.ts
  • lib/commands/create-project.ts
  • lib/commands/extensibility/install-extension.ts
  • lib/commands/extensibility/list-extensions.ts
  • lib/commands/extensibility/uninstall-extension.ts
  • lib/commands/fonts.ts
  • lib/commands/generate-assets.ts
  • lib/commands/install.ts
  • lib/commands/list-platforms.ts
  • lib/commands/migrate.ts
  • lib/commands/native-add.ts
  • lib/commands/platform-clean.ts
  • lib/commands/plugin/add-plugin.ts
  • lib/commands/plugin/build-plugin.ts
  • lib/commands/plugin/create-plugin.ts
  • lib/commands/plugin/list-plugins.ts
  • lib/commands/plugin/remove-plugin.ts
  • lib/commands/plugin/update-plugin.ts
  • lib/commands/preview.ts
  • lib/commands/remove-platform.ts
  • lib/commands/resources/resources-update.ts
  • lib/commands/run.ts
  • lib/commands/test-init.ts
  • lib/commands/update-platform.ts
  • lib/commands/update.ts
  • lib/common/bootstrap.ts
  • lib/common/codeGeneration/code-generation.d.ts
  • lib/common/codeGeneration/code-printer.ts
  • lib/common/commands/analytics.ts
  • lib/common/commands/autocompletion.ts
  • lib/common/commands/device/device-log-stream.ts
  • lib/common/commands/device/get-file.ts
  • lib/common/commands/device/list-applications.ts
  • lib/common/commands/device/list-devices.ts
  • lib/common/commands/device/list-files.ts
  • lib/common/commands/device/put-file.ts
  • lib/common/commands/device/run-application.ts
  • lib/common/commands/device/stop-application.ts
  • lib/common/commands/device/uninstall-application.ts
  • lib/common/commands/doctor.ts
  • lib/common/commands/generate-messages.ts
  • lib/common/commands/help.ts
  • lib/common/commands/package-manager-get.ts
  • lib/common/commands/package-manager-set.ts
  • lib/common/commands/post-install.ts
  • lib/common/commands/preuninstall.ts
  • lib/common/commands/proxy/proxy-base.ts
  • lib/common/commands/proxy/proxy-clear.ts
  • lib/common/commands/proxy/proxy-get.ts
  • lib/common/commands/proxy/proxy-set.ts
  • lib/common/constants.ts
  • lib/common/declarations.d.ts
  • lib/common/decorators.ts
  • lib/common/definitions/commands-service.d.ts
  • lib/common/definitions/config.d.ts
  • lib/common/definitions/json-file-settings-service.d.ts
  • lib/common/definitions/logger.d.ts
  • lib/common/definitions/mobile.d.ts
  • lib/common/dispatchers.ts
  • lib/common/helpers.ts
  • lib/common/host-info.ts
  • lib/common/logger/appenders/emit-appender.ts
  • lib/common/messages/messages.ts
  • lib/common/mobile/android/android-debug-bridge-result-handler.ts
  • lib/common/mobile/android/android-debug-bridge.ts
  • lib/common/mobile/android/android-device-file-system.ts
  • lib/common/mobile/android/android-device-hash-service.ts
  • lib/common/mobile/android/android-device.ts
  • lib/common/mobile/android/android-emulator-services.ts
  • lib/common/mobile/android/android-ini-file-parser.ts
  • lib/common/mobile/android/android-log-filter.ts
  • lib/common/mobile/android/device-android-debug-bridge.ts
  • lib/common/mobile/android/genymotion/genymotion-service.ts
  • lib/common/mobile/android/genymotion/virtualbox-service.ts
  • lib/common/mobile/android/logcat-helper.ts
  • lib/common/mobile/application-manager-base.ts
  • lib/common/mobile/device-emitter.ts
  • lib/common/mobile/device-log-emitter.ts
  • lib/common/mobile/device-log-provider-base.ts
  • lib/common/mobile/device-log-provider.ts
  • lib/common/mobile/ios/device/ios-application-manager.ts
  • lib/common/mobile/ios/device/ios-device.ts
  • lib/common/mobile/ios/ios-device-base.ts
  • lib/common/mobile/ios/ios-log-filter.ts
  • lib/common/mobile/ios/simulator/ios-emulator-services.ts
  • lib/common/mobile/ios/simulator/ios-sim-resolver.ts
  • lib/common/mobile/ios/simulator/ios-simulator-application-manager.ts
  • lib/common/mobile/ios/simulator/ios-simulator-device.ts
  • lib/common/mobile/ios/simulator/ios-simulator-file-system.ts
  • lib/common/mobile/ios/simulator/ios-simulator-log-provider.ts
  • lib/common/mobile/local-to-device-path-data-factory.ts
  • lib/common/mobile/log-filter.ts
  • lib/common/mobile/mobile-core/android-device-discovery.ts
  • lib/common/mobile/mobile-core/android-emulator-discovery.ts
  • lib/common/mobile/mobile-core/android-process-service.ts
  • lib/common/mobile/mobile-core/device-discovery.ts
  • lib/common/mobile/mobile-core/devices-service.ts
  • lib/common/mobile/mobile-core/ios-device-discovery.ts
  • lib/common/mobile/mobile-core/ios-simulator-discovery.ts
  • lib/common/mobile/mobile-helper.ts
  • lib/common/mobile/wp8/wp8-emulator-services.ts
  • lib/common/project-helper.ts
  • lib/common/prompter.ts
  • lib/common/resource-loader.ts
  • lib/common/services/auto-completion-service.ts
  • lib/common/services/help-service.ts
  • lib/common/services/ios-notification-service.ts
  • lib/common/services/json-file-settings-service.ts
  • lib/common/services/lock-service.ts
  • lib/common/services/message-contract-generator.ts
  • lib/common/services/messages-service.ts
  • lib/common/services/micro-templating-service.ts
  • lib/common/services/project-files-manager.ts
  • lib/common/services/project-files-provider-base.ts
  • lib/common/services/proxy-service.ts
  • lib/common/services/qr.ts
  • lib/common/services/settings-service.ts
  • lib/common/services/xcode-select-service.ts
  • lib/common/test/test-bootstrap.ts
  • lib/common/test/unit-tests/android-application-manager.ts
  • lib/common/test/unit-tests/android-log-filter.ts
  • lib/common/test/unit-tests/appbuilder/device-log-provider.ts
  • lib/common/test/unit-tests/helpers.ts
  • lib/common/test/unit-tests/host-info.ts
  • lib/common/test/unit-tests/ios-log-filter.ts
  • lib/common/test/unit-tests/log-filter.ts
  • lib/common/test/unit-tests/logger.ts
  • lib/common/test/unit-tests/messages-service.ts
  • lib/common/test/unit-tests/mobile/android-debug-bridge.ts
  • lib/common/test/unit-tests/mobile/android-device-discovery.ts
  • lib/common/test/unit-tests/mobile/android-device-file-system.ts
  • lib/common/test/unit-tests/mobile/android-virtual-device-service.ts
  • lib/common/test/unit-tests/mobile/android/logcat-helper.ts
  • lib/common/test/unit-tests/mobile/application-manager-base.ts
  • lib/common/test/unit-tests/mobile/device-log-provider.ts
  • lib/common/test/unit-tests/mobile/devices-service.ts
  • lib/common/test/unit-tests/mobile/genymotion/genymotion-service.ts
  • lib/common/test/unit-tests/mobile/ios-simulator-discovery.ts
  • lib/common/test/unit-tests/mocks/decorators-invoke-before.ts
  • lib/common/test/unit-tests/preuninstall.ts
  • lib/common/test/unit-tests/project-files-provider-base.ts
  • lib/common/test/unit-tests/services/files-hash-service.ts
  • lib/common/test/unit-tests/services/help-service.ts
  • lib/common/test/unit-tests/services/json-file-settings-service.ts
  • lib/common/test/unit-tests/services/net-service.ts
  • lib/common/test/unit-tests/stubs.ts
  • lib/common/test/unit-tests/xcode-select-service.ts
  • lib/common/utils.ts
  • lib/common/validators/project-name-validator.ts
  • lib/common/verify-node-version.ts
  • lib/common/yok.ts
  • lib/config.ts
  • lib/constants.ts
  • lib/controllers/build-controller.ts
  • lib/controllers/debug-controller.ts
  • lib/controllers/deploy-controller.ts
  • lib/controllers/migrate-controller.ts
  • lib/controllers/platform-controller.ts
  • lib/controllers/update-controller-base.ts
  • lib/controllers/update-controller.ts
  • lib/data/controller-data-base.ts
  • lib/data/platform-data.ts
  • lib/data/run-data.ts
  • lib/declarations.d.ts
  • lib/definitions/build.d.ts
  • lib/definitions/debug.d.ts
  • lib/definitions/files-hash-service.d.ts
  • lib/definitions/gradle.d.ts
  • lib/definitions/livesync.d.ts
  • lib/definitions/lock-service.d.ts
  • lib/definitions/marking-mode-service.d.ts
  • lib/definitions/migrate.d.ts
  • lib/definitions/nativescript-dev-xcode.d.ts
  • lib/definitions/pacote-service.d.ts
  • lib/definitions/platform.d.ts
  • lib/definitions/plugins.d.ts
  • lib/definitions/prepare.d.ts
  • lib/definitions/project.d.ts
  • lib/definitions/prompter.d.ts
  • lib/definitions/run.d.ts
  • lib/definitions/terminal-spinner-service.d.ts
  • lib/detached-processes/cleanup-js-subprocess.ts
  • lib/device-path-provider.ts
  • lib/device-sockets/ios/app-debug-socket-proxy-factory.ts
  • lib/device-sockets/ios/notification.ts
  • lib/device-sockets/ios/socket-request-executor.ts
  • lib/helpers/android-bundle-validator-helper.ts
  • lib/helpers/deploy-command-helper.ts
  • lib/helpers/network-connectivity-validator.ts
  • lib/helpers/options-track-helper.ts
  • lib/helpers/platform-command-helper.ts
  • lib/helpers/version-validator-helper.ts
  • lib/key-commands/index.ts
  • lib/nativescript-cli-lib-bootstrap.ts
  • lib/nativescript-cli.ts
  • lib/node-package-manager.ts
  • lib/options.ts
  • lib/package-installation-manager.ts
  • lib/package-manager.ts
  • lib/platform-command-param.ts
  • lib/pnpm-package-manager.ts
  • lib/providers/project-files-provider.ts
  • lib/resolvers/livesync-service-resolver.ts
  • lib/services/analytics/analytics.d.ts
  • lib/services/android-device-debug-service.ts
  • lib/services/android-project-service.ts
  • lib/services/android-resources-migration-service.ts
  • lib/services/android/gradle-build-args-service.ts
  • lib/services/android/gradle-build-service.ts
  • lib/services/android/gradle-command-service.ts
  • lib/services/apple-portal/apple-portal-application-service.ts
  • lib/services/apple-portal/apple-portal-cookie-service.ts
  • lib/services/apple-portal/apple-portal-session-service.ts
  • lib/services/apple-portal/definitions.d.ts
  • lib/services/apple-portal/srp/srp-wrapper.ts
  • lib/services/build-artifacts-service.ts
  • lib/services/build-info-file-service.ts
  • lib/services/cocoapods-platform-manager.ts
  • lib/services/cocoapods-service.ts
  • lib/services/debug-data-service.ts
  • lib/services/device/device-install-app-service.ts
  • lib/services/doctor-service.ts
  • lib/services/files-hash-service.ts
  • lib/services/hmr-status-service.ts
  • lib/services/ios-device-debug-service.ts
  • lib/services/ios-extensions-service.ts
  • lib/services/ios-log-filter.ts
  • lib/services/ios-native-target-service.ts
  • lib/services/ios-project-service.ts
  • lib/services/ios-provision-service.ts
  • lib/services/ios-watch-app-service.ts
  • lib/services/ios/export-options-plist-service.ts
  • lib/services/ios/xcodebuild-args-service.ts
  • lib/services/ios/xcodebuild-service.ts
  • lib/services/ip-service.ts
  • lib/services/itmstransporter-service.ts
  • lib/services/livesync-process-data-service.ts
  • lib/services/livesync/android-device-livesync-service-base.ts
  • lib/services/livesync/android-device-livesync-service.ts
  • lib/services/livesync/android-livesync-service.ts
  • lib/services/livesync/android-livesync-tool.ts
  • lib/services/livesync/device-livesync-service-base.ts
  • lib/services/livesync/ios-device-livesync-service.ts
  • lib/services/livesync/livesync-socket.ts
  • lib/services/livesync/platform-livesync-service-base.ts
  • lib/services/log-parser-service.ts
  • lib/services/log-source-map-service.ts
  • lib/services/marking-mode-service.ts
  • lib/services/metadata-filtering-service.ts
  • lib/services/performance-service.ts
  • lib/services/platform-environment-requirements.ts
  • lib/services/platform-project-service-base.ts
  • lib/services/platform/add-platform-service.ts
  • lib/services/platform/platform-validation-service.ts
  • lib/services/platform/prepare-native-platform-service.ts
  • lib/services/platforms-data-service.ts
  • lib/services/project-changes-service.ts
  • lib/services/project-cleanup-service.ts
  • lib/services/project-data-service.ts
  • lib/services/project-service.ts
  • lib/services/project-templates-service.ts
  • lib/services/start-service.ts
  • lib/services/test-initialization-service.ts
  • lib/services/timeline-profiler-service.ts
  • lib/services/user-settings-service.ts
  • lib/services/versions-service.ts
  • lib/services/xcproj-service.ts
  • lib/tools/config-manipulation/config-transformer.ts
  • lib/tools/node-modules/node-modules-builder.ts
  • lib/tools/node-modules/node-modules-dependencies-builder.ts
  • lib/yarn-package-manager.ts
  • lib/yarn2-package-manager.ts
  • package.json
  • test/android-tools-info.ts
  • test/bun-package-manager.ts
  • test/cocoapods-service.ts
  • test/commands/post-install.ts
  • test/config/config-json.ts
  • test/controllers/update-controller.ts
  • test/helpers/platform-command-helper.ts
  • test/ios-project-service.ts
  • test/node-package-manager.ts
  • test/package-installation-manager.ts
  • test/platform-commands.ts
  • test/post-install.ts
  • test/preuninstall.ts
  • test/project-files-provider.ts
  • test/project-name-service.ts
  • test/project-service.ts
  • test/project-templates-service.ts
  • test/services/android-device-debug-service.ts
  • test/services/android-plugin-build-service.ts
  • test/services/android-project-service.ts
  • test/services/ios-debugger-port-service.ts
  • test/services/ios-device-debug-service.ts
  • test/services/ios-log-filter.ts
  • test/services/ios/export-options-plist-service.ts
  • test/services/ios/xcodebuild-service.ts
  • test/services/ip-service.ts
  • test/services/livesync/android-device-livesync-service-base.ts
  • test/services/livesync/android-livesync-tool.ts
  • test/services/log-parser-service.ts
  • test/services/log-source-map-service.ts
  • test/services/metadata-filtering-service.ts
  • test/services/platform-environment-requirements.ts
  • test/services/platform/add-platform-service.ts
  • test/services/test-execution-service.ts
  • test/services/user-settings-service.ts
  • test/stubs.ts
  • tslint.json

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@edusperoni edusperoni Awaiting requested review from edusperoni

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@NathanWalker