Skip to content

fix(core): guard undefined navigation queue entry in Frame - #11326

Open
NathanWalker wants to merge 1 commit into
mainfrom
fix/frame-navigation-queue-guard
Open

fix(core): guard undefined navigation queue entry in Frame#11326
NathanWalker wants to merge 1 commit into
mainfrom
fix/frame-navigation-queue-guard

Conversation

@NathanWalker

Copy link
Copy Markdown
Contributor

A goBack() queued while another navigation is still executing (e.g. an interactive dismiss that finished out-of-band) can leave the head of the navigation queue without an entry, since performGoBack hasn't populated it yet. Skip the head safely instead of crashing on reading .resolvedPage.

@nx-cloud

nx-cloud Bot commented Aug 1, 2026

Copy link
Copy Markdown

View your CI Pipeline Execution ↗ for commit cafe076

Command Status Duration Result
nx test apps-automated -c=android ✅ Succeeded 3m 46s View ↗
nx run-many --target=test --configuration=ci --... ✅ Succeeded <1s View ↗

💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗


☁️ Nx Cloud last updated this comment at 2026-08-03 20:34:59 UTC

@NathanWalker NathanWalker added this to the 9.1 milestone Aug 1, 2026
Comment thread packages/core/ui/frame/frame-common.ts Outdated
A goBack() queued while another navigation is still executing (e.g. an
interactive dismiss that finished out-of-band) can leave the head of the
navigation queue without an entry, since performGoBack hasn't populated it
yet. Skip the head safely instead of crashing on reading `.resolvedPage`.
@NathanWalker
NathanWalker force-pushed the fix/frame-navigation-queue-guard branch from a348784 to cafe076 Compare August 3, 2026 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants