feat(ios): iosContentInsetAdjustmentBehavior for ScrollView with safe-area aware layouts - #11324
Open
NathanWalker wants to merge 2 commits into
Open
feat(ios): iosContentInsetAdjustmentBehavior for ScrollView with safe-area aware layouts#11324NathanWalker wants to merge 2 commits into
NathanWalker wants to merge 2 commits into
Conversation
…-area aware layouts Adds an iOS-only `iosContentInsetAdjustmentBehavior` property to ScrollView (mapping to UIScrollView.contentInsetAdjustmentBehavior, default `never` to preserve existing behavior). When iOS manages insets, ScrollView no longer subtracts safe-area insets manually — avoiding scroll drift with large titles — and nested layouts (Absolute, Dock, Flexbox, Grid, Stack, Wrap) skip their own safe-area subtraction via IOSHelper.hasIOSManagedInsetAncestor to prevent double-counting the nav-bar inset.
|
View your CI Pipeline Execution ↗ for commit 2e9a3ab
💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗ ☁️ Nx Cloud last updated this comment at |
CatchABus
reviewed
Aug 1, 2026
CatchABus
reviewed
Aug 1, 2026
CatchABus
reviewed
Aug 1, 2026
CatchABus
requested changes
Aug 1, 2026
CatchABus
requested changes
Aug 1, 2026
…-area skip - apply contentInsetAdjustmentBehavior through the property's setNative (runtime changes now take effect) instead of on every onLayout pass - move the managed-inset ancestor check into View.getSafeAreaInsets so layouts no longer repeat it individually - only request layout on Apple platforms (affectsLayout: __APPLE__)
NathanWalker
force-pushed
the
feat/ios-scrollview-inset-behavior
branch
from
August 3, 2026 20:43
2e9a3ab to
8a7d94f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an iOS-only
iosContentInsetAdjustmentBehaviorproperty to ScrollView (mapping to UIScrollView.contentInsetAdjustmentBehavior, defaultneverto preserve existing behavior). When iOS manages insets, ScrollView no longer subtracts safe-area insets manually (avoiding scroll drift with large titles) and nested layouts (Absolute, Dock, Flexbox, Grid, Stack, Wrap) skip their own safe-area subtraction via IOSHelper.hasIOSManagedInsetAncestor to prevent double-counting the nav-bar inset.