Conversation
Co-authored-by: krishkat <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this round, I consider the core library complete.
After some adjustments to the Source Generator and the satellite libraries, I'm aiming for a Preview release next week.
There are no major feature additions, but a few adjustments were made:
Surrogates now work on every platform, and the legacy UnionAttribute is now handled by the reflection tier, among others.
I've settled on how
MessagePack.Annotationsis handled for compatibility.Every compatible attribute is forwarded to the main assembly via
TypeForwardedTo.The goal is to preserve compatibility as far as possible for pre-built v2/v3 DLLs that carry nothing but the annotations.
Those are handled correctly by the reflection layer (ReflectionObjectFormatter / ReflectionUnionFormatter).
I've ported the v3 unit tests as part of the test suite.
They proved useful for edge-case handling, and they also made me realize that unless these are handled properly, it's hard to claim compatibility lightly.
I've also added property-based testing with CsCheck and fuzzing with SharpFuzz.