Skip to content

Use ParamSpec for run_in_threadpool - #2375

Merged
Kludex merged 3 commits into
masterfrom
proper-annotate-run-in-threadpool
Dec 16, 2023
Merged

Kludex merged 3 commits into
masterfrom
proper-annotate-run-in-threadpool

Conversation

@Kludex

@Kludex Kludex commented Dec 16, 2023

Copy link
Copy Markdown
Owner

No description provided.

@Kludex
Kludex requested a review from a team December 16, 2023 12:17
Comment thread starlette/concurrency.py


# TODO: We should use `ParamSpec` here, but mypy doesn't support it yet.
# Check https://github.com/python/mypy/issues/12278 for more details.

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was solved some time ago. 馃檹

@michaeloliverx michaeloliverx left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good addition

@Kludex
Kludex enabled auto-merge (squash) December 16, 2023 12:49
@Kludex
Kludex merged commit 9a213c1 into master Dec 16, 2023
@Kludex
Kludex deleted the proper-annotate-run-in-threadpool branch December 16, 2023 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants