Skip to content

Take weak ETags in consideration on StaticFiles - #2334

Merged
Kludex merged 9 commits into
Kludex:masterfrom
neolooong:fix-staticfile-etag
Dec 16, 2023
Merged

Kludex merged 9 commits into
Kludex:masterfrom
neolooong:fix-staticfile-etag

Conversation

@neolooong

Copy link
Copy Markdown
Contributor

Summary

fix #2298.

Checklist

  • I understand that this PR may be closed in case there was no previous discussion. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.

@Kludex
Kludex requested a review from karpetrosyan December 1, 2023 16:35
Comment thread starlette/staticfiles.py Outdated
@karpetrosyan karpetrosyan added the bug Something isn't working label Dec 4, 2023
@Kludex Kludex mentioned this pull request Dec 10, 2023
3 tasks
Comment thread starlette/staticfiles.py Outdated
@Kludex Kludex changed the title Fix staticfile etag Take weak ETags in consideration on StaticFiles Dec 16, 2023
@Kludex
Kludex merged commit 3c8ab8e into Kludex:master Dec 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Strong and weak etags for StaticFiles

3 participants