fix: pass usedforsecurity to hashlib.md5 to fix error on FIPS-enabled systems - #1366
Merged
adriangb merged 15 commits intoDec 17, 2021
Merged
Conversation
adriangb
commented
Dec 15, 2021
adriangb
left a comment
Contributor
Author
There was a problem hiding this comment.
One thing I wasn't sure about: do we want a test that monkey patches hashlib to verify that we are passing usedforsecurity=False? Seems like overkill to me
lovelydinosaur
approved these changes
Dec 17, 2021
|
@adriangb Fantastic, thanks! I've invited you as a maintainer, so that you can merge this PR yourself. |
Contributor
Author
|
Worked perfectly, thank you Tom |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1365