Conversation
hanneskuettner
force-pushed
the
fix/session-middleware-handle-invalid-cookie-format
branch
from
August 12, 2021 11:33
024c811 to
2b64854
Compare
JayH5
approved these changes
Aug 14, 2021
JayH5
left a comment
Contributor
There was a problem hiding this comment.
Seems reasonable, thanks 馃憤
hanneskuettner
deleted the
fix/session-middleware-handle-invalid-cookie-format
branch
August 16, 2021 13:24
|
Great patch, thanks. Eagerly awaiting the release. |
|
Just wanted to say I've tested this in my project and it works well. No more non-recoverable Internal Server Errors when passing in malformed session cookies- just an elegant blank session. Glad to see people stress testing exploitation vectors on Starlette to make it more robust! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
SessionMiddlewaredoes not catch all possible exceptions ofTimestampSigner.unsign, specifically there is an edge case where aBadSignatureexception can be raised by the method if a totally bogus session cookie is provided that does not match the expected format.This PR broadens the caught exceptions (since all the other exceptions inherit
BadSignature) and fixes the issue.The issue can be reproduced by running the new test without the fix applied.