Merged
Conversation
falkben
reviewed
Jun 23, 2021
graingert
approved these changes
Jul 7, 2021
Owner
Author
|
@auvipy took me some time, but here you have 馃槄 |
Owner
Author
|
I've opened a PR on Strawberry to add an integration page with Starlette: https://strawberry.rocks/docs/integrations/starlette It was promptly accepted. 馃帀 Then, I've updated the documentation on the I'd like further approval, and I'm also not in a hurry to get this merged. :) |
JayH5
approved these changes
Oct 2, 2021
JayH5
left a comment
Contributor
There was a problem hiding this comment.
Some suggestions for the docs but 馃殌
Co-authored-by: Jamie Hewland <[email protected]>
Co-authored-by: Jamie Hewland <[email protected]>
Owner
Author
@JayH5 Thanks for the suggestions! 馃槑 |
|
it's a cool idea. but why?) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes GraphQL entirely. I've assumed that we don't need to document the removal, just the CHANGELOG is enough (correct me otherwise).
The idea is to merge this PR before 1.0. There's no hurry on this, once we fulfill the other requirements, we can come back to this PR.
Related issues