Fix crash in MeasureAndLayoutDelegate.forceMeasureTheSubtree() - #127
Merged
Igor Demin (igordmn) merged 1 commit intoNov 25, 2021
Merged
Conversation
It was happening because we were asserting that the node will not be in NeedsRemeasure state anymore as a result. However it is not always true as we can skip remeasuring for nodes which are not placed and can't affect the parent size. The updated logic will correctly skip such unplaced subtrees. Fixes: 206732855 Test: new test in NodesRemeasuredOnceTest Change-Id: I37abed763d269b51b858a86c820fd64038eca505
Nikolay Igotti (olonho)
approved these changes
Nov 25, 2021
Zahari Zahariev (harryzz)
pushed a commit
to harryzz/compose-multiplatform-core
that referenced
this pull request
Jul 28, 2026
If Bundle contents can be extracted as a Reference, allow parsing the Bundle contents as a Reference. When navigating via deeplink URI, the user is required to string-ify navigation arguments in order to append them to the URI as query parameters. This PR supports retrieving a Reference type from a Bundle ## Proposed Changes - replace `NavType#ReferenceType::parseValue`'s method functionality with `Integer.parseInt` ## Testing Updated `NavTypeTest` to validate that reference types can be inserted and retrieved from a Bundle. Test: /gradlew test connectedCheck ## Issues Fixed Fixes: b/179166693 This is an imported pull request from androidx#127. Resolves JetBrains#127 Github-Pr-Head-Sha: 78179a9 GitOrigin-RevId: edf5410 Change-Id: I80f4d03a07b04756cd7ea1f3cf43688a115116e4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes JetBrains/compose-multiplatform#1464
Cherry-picked from https://android-review.googlesource.com/c/platform/frameworks/support/+/1896692
It was happening because we were asserting that the node will not be in NeedsRemeasure state anymore as a result. However it is not always true as we can skip remeasuring for nodes which are not placed and can't affect the parent size. The updated logic will correctly skip such unplaced subtrees.
Fixes: 206732855
Test: new test in NodesRemeasuredOnceTest
Change-Id: I37abed763d269b51b858a86c820fd64038eca505