EvalSourceMapDevToolPlugin: add ability to filter which modules get sourcemapped

MagicDuck · MagicDuck · commit 59d9b9f8aaed · 2018-02-08T17:33:55.000-08:00
see: webpack#6450 This is useful to filter out stuff you don't care about or stuff that's very large and screws up with devtools.
diff --git a/lib/EvalSourceMapDevToolModuleTemplatePlugin.js b/lib/EvalSourceMapDevToolModuleTemplatePlugin.js
@@ -19,9 +19,14 @@ class EvalSourceMapDevToolModuleTemplatePlugin {
 	apply(moduleTemplate) {
 		const self = this;
 		const options = this.options;
+		const matchModule = ModuleFilenameHelpers.matchObject.bind(ModuleFilenameHelpers, options);
 		moduleTemplate.hooks.module.tap("EvalSourceMapDevToolModuleTemplatePlugin", (source, module) => {
 			if(source.__EvalSourceMapDevToolData)
 				return source.__EvalSourceMapDevToolData;
+			if(!matchModule(module.resource)) {
+				return source;
+			}
+
 			let sourceMap;
 			let content;
 			if(source.sourceAndMap) {
diff --git a/test/configCases/source-map/exclude-modules-source-map/index.js b/test/configCases/source-map/exclude-modules-source-map/index.js
@@ -0,0 +1,8 @@
+it("bundle1 should include eval sourcemapped test1.js and test2.js as is", function() {
+	var fs = require("fs");
+	var path = require("path");
+	var bundle1 = fs.readFileSync(path.join(__dirname, "bundle1.js"), "utf-8");
+	bundle1.should.containEql("eval(\"var test1marker");
+	bundle1.should.containEql("var test2marker");
+	bundle1.should.not.containEql("eval(\"var test2marker");
+});
diff --git a/test/configCases/source-map/exclude-modules-source-map/test1.js b/test/configCases/source-map/exclude-modules-source-map/test1.js
@@ -0,0 +1,3 @@
+var test1marker = {};
+
+module.exports = test1marker;
diff --git a/test/configCases/source-map/exclude-modules-source-map/test2.js b/test/configCases/source-map/exclude-modules-source-map/test2.js
@@ -0,0 +1,3 @@
+var test2marker = {};
+
+module.exports = test2marker;
diff --git a/test/configCases/source-map/exclude-modules-source-map/webpack.config.js b/test/configCases/source-map/exclude-modules-source-map/webpack.config.js
@@ -0,0 +1,22 @@
+var webpack = require("../../../../");
+module.exports = {
+	node: {
+		__dirname: false,
+		__filename: false
+	},
+	entry: {
+		bundle0: ["./index.js"],
+		bundle1: ["./test1.js", "./test2.js"]
+	},
+	output: {
+		filename: "[name].js"
+	},
+	plugins: [
+		new webpack.EvalSourceMapDevToolPlugin({
+			include: /\.js$/,
+			exclude: /test2\.js/,
+			module: true,
+			columns: false
+		})
+	]
+};

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	`+var test1marker = {};`
	`2`	`+`
	`3`	`+module.exports = test1marker;`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	`+var test2marker = {};`
	`2`	`+`
	`3`	`+module.exports = test2marker;`