ci: allow DCO remediation commits - #138
Open
romeokienzler wants to merge 1 commit into
Open
romeokienzler wants to merge 1 commit into
romeokienzler wants to merge 1 commit into
Conversation
The DCO app ignores remediation commits unless allowRemediationCommits is set in .github/dco.yml on the default branch. Without this, retroactive sign-offs are silently discarded -- the third-party remediation already pushed to #137 left that PR's count unchanged at 153. Enables both individual and third-party remediation. thirdParty is needed because one of the vendored commits was authored by whitesource-ets[bot], which cannot sign off for itself, and the app nests the third-party check inside the individual one so both flags are required. Co-Authored-By: Claude Opus 5 (1M context) <[email protected]> Signed-off-by: Romeo Kienzler <[email protected]>
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enables retroactive DCO sign-offs so the vendored history in #137 can be remediated.
Why
The DCO app reads
allowRemediationCommitsfrom.github/dco.ymlon the default branch, and remediation is off by default. Without this file, remediation commits are parsed but silently discarded.This is not theoretical — a correctly-formed third-party remediation commit was already pushed to #137 (
8e1086c), and the DCO count stayed at 153 instead of dropping to 152. That commit only starts counting once this merges.Why both flags
individual: truecovers the 152 commits whose authors can sign off for themselves.thirdParty: trueis needed for one commit authored bywhitesource-ets[bot], which cannot sign off for itself. Note that the app nests the third-party check inside the individual check (lib/dco.js), sothirdPartyhas no effect unlessindividualis also true.Context
#137 vendors
GeoDN-Discovery/overviewsas a git subtree, bringing 153 upstream commits that predate this repo's DCO requirement. Rewriting that history to add sign-offs is not an option: it would flatten the subtree merge, and one person cannot sign off on another's commits. Remediation commits are the mechanism the DCO app provides for exactly this, and they leave history intact.Merging this does not change any commit or sign-off state by itself — it only makes the remediation commits in #137 count.
🤖 Generated with Claude Code