Skip to content

refactor!: rename cloudevent to cloud_event - #167

Merged
KaylaNguyen merged 4 commits into
masterfrom
cloudevent
Nov 10, 2021
Merged

KaylaNguyen merged 4 commits into
masterfrom
cloudevent

Conversation

@KaylaNguyen

Copy link
Copy Markdown
Contributor

No description provided.

@google-cla google-cla Bot added the cla: yes label Nov 9, 2021
@KaylaNguyen KaylaNguyen linked an issue Nov 9, 2021 that may be closed by this pull request

@grant grant left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Couple comments.

Comment thread .github/workflows/conformance.yml Outdated
Comment thread src/functions_framework/_function_registry.py Outdated
@KaylaNguyen
KaylaNguyen requested a review from grant November 10, 2021 00:01

@grant grant left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, didn't find needed changes.

@KaylaNguyen
KaylaNguyen merged commit 99a9df6 into master Nov 10, 2021
@KaylaNguyen
KaylaNguyen deleted the cloudevent branch November 10, 2021 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CloudEvent signature decorator should be snake case

2 participants