feat: Declarative function signatures for python - #160
Merged
Merged
Conversation
matthewrobertson
requested changes
Oct 25, 2021
grant
approved these changes
Oct 25, 2021
grant
left a comment
Contributor
There was a problem hiding this comment.
Great PR. I've requested a few changes.
grant
suggested changes
Oct 25, 2021
grant
left a comment
Contributor
There was a problem hiding this comment.
Reviewing further, I don't think we want to support @function_framework.event, following the Node implementation and CloudEvent future interface for events.
anniefu
reviewed
Oct 25, 2021
grant
approved these changes
Oct 26, 2021
anniefu
approved these changes
Oct 26, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow users to systematically register their function signature type:
User signature type is searched in the following order:
If none of the above is set, signature type defaults to be "http".