Skip to content

Add support for background to CloudEvent conversion - #116

Merged
mtraver merged 7 commits into
masterfrom
event-conversion
Mar 9, 2021
Merged

Add support for background to CloudEvent conversion#116
mtraver merged 7 commits into
masterfrom
event-conversion

Conversation

@mtraver

@mtraver mtraver commented Mar 8, 2021

Copy link
Copy Markdown
Contributor

No description provided.

@mtraver
mtraver requested review from asriniva, di and grant March 8, 2021 21:45
@google-cla google-cla Bot added the cla: yes label Mar 8, 2021
@mtraver

mtraver commented Mar 8, 2021

Copy link
Copy Markdown
Contributor Author

Unit tests pass but coverage is at 99.17%.

Lint says:

lint run-test: commands[1] | isort -rc -c src tests setup.py conftest.py
ERROR: /home/runner/work/functions-framework-python/functions-framework-python/src/functions_framework/convert.py Imports are incorrectly sorted and/or formatted.
ERROR: /home/runner/work/functions-framework-python/functions-framework-python/src/functions_framework/__init__.py Imports are incorrectly sorted and/or formatted.
ERROR: /home/runner/work/functions-framework-python/functions-framework-python/tests/test_convert.py Imports are incorrectly sorted and/or formatted.
/home/runner/work/functions-framework-python/functions-framework-python/.tox/lint/lib/python3.9/site-packages/isort/main.py:1133: UserWarning: W0501: The following deprecated CLI flags were used and ignored: -rc!
  warn(
/home/runner/work/functions-framework-python/functions-framework-python/.tox/lint/lib/python3.9/site-packages/isort/main.py:1137: UserWarning: W0500: Please see the 5.0.0 Upgrade guide: https://pycqa.github.io/isort/docs/upgrade_guides/5.0.0/
  warn(
ERROR: InvocationError for command /home/runner/work/functions-framework-python/functions-framework-python/.tox/lint/bin/isort -rc -c src tests setup.py conftest.py (exited with code 1)

@mtraver

mtraver commented Mar 8, 2021

Copy link
Copy Markdown
Contributor Author

Ok, all checks pass! Yay!

asriniva
asriniva reviewed Mar 9, 2021
View reviewed changes
Comment thread tests/test_convert.py Outdated
grant
grant approved these changes Mar 9, 2021
View reviewed changes

@grant grant left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 🥳

Please look at the review comments – there are some requested minor changes.
No major blocking comments, so approving. LMK if any comments could be clarified.

Comment thread src/functions_framework/background.py Outdated
Comment thread src/functions_framework/background.py Outdated
Comment thread src/functions_framework/convert.py
Comment thread src/functions_framework/convert.py
Comment thread src/functions_framework/background.py
@mtraver
mtraver merged commit eb6761e into master Mar 9, 2021
@mtraver
mtraver deleted the event-conversion branch March 9, 2021 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@di di Awaiting requested review from di
2 more reviewers
@asriniva asriniva asriniva left review comments
@grant grant grant approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mtraver @asriniva @grant