Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: ExcelDataReader/ExcelDataReader
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: develop
Choose a base ref
...
head repository: ExcelDataReader/ExcelDataReader
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: nullable
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 5 commits
  • 71 files changed
  • 1 contributor

Commits on Aug 30, 2026

  1. Enable nullable annotations across reader codebase 

    Apply nullable reference annotations and guarded flows across the reader, factory, core formats, and dataset surfaces.
Change NullReferenceException to ObjectDisposedException in a few places.
    @appel1
    appel1 committed Aug 30, 2026
    Configuration menu
    Copy the full SHA
    f1596ae View commit details
    Browse the repository at this point in the history

  2. Align reader null cell behavior with IDataReader contract 

    Update GetValue-based expectations and empty-row checks in tests to match DBNull.Value semantics for null/error cells.
Make GetString match IDataRecord contract by throwing on DBNull-backed cells, and update tests to assert IsDBNull plus InvalidCastException where appropriate.
    @appel1
    appel1 committed Aug 30, 2026
    Configuration menu
    Copy the full SHA
    0257ab3 View commit details
    Browse the repository at this point in the history

  3. Update README

    @appel1
    appel1 committed Aug 30, 2026
    Configuration menu
    Copy the full SHA
    5cac5b6 View commit details
    Browse the repository at this point in the history

  4. Fix VisibleState nullability: widen IWorksheet.VisibleState to string… 

    …? and revert CsvWorksheet to return null

IWorksheet.VisibleState was left non-nullable while sibling properties
CodeName and HeaderFooter were correctly made nullable. To satisfy the
non-null contract under nullable annotations, CsvWorksheet.VisibleState
had been changed from returning null to returning "visible", which is
an unintended behavior change for CSV consumers rather than an
annotation fix.

Widen IWorksheet.VisibleState to string?, consistent with
CodeName/HeaderFooter, and revert CsvWorksheet.VisibleState to null,
restoring original develop behavior. No suppressions needed since
XlsWorksheet/XlsxWorksheet already always assign non-null values.

Also adds a test asserting VisibleState is null for CSV readers.
    @appel1
    appel1 committed Aug 30, 2026
    Configuration menu
    Copy the full SHA
    2e6ad21 View commit details
    Browse the repository at this point in the history

  5. Add GetFieldType asserts for DbNull case

    @appel1
    appel1 committed Aug 30, 2026
    Configuration menu
    Copy the full SHA
    fe924f4 View commit details
    Browse the repository at this point in the history
Loading