This repository was archived by the owner on Aug 2, 2022. It is now read-only.
Fix packed transaction version conversion -- Develop - #9843
Merged
linhuang-blockone merged 2 commits intoJan 4, 2021
Merged
linhuang-blockone merged 2 commits into
linhuang-blockone merged 2 commits into
Conversation
heifner
approved these changes
Jan 4, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Description
This PR is to merge the fix from #9828 to develop.
https://blockone.atlassian.net/browse/EPE-579
In Jungle testnet, LIBs were not advancing in a mixed of Rel. 2.0.x and Rel. 2.1.x nodes.
This was due to 2.0.x validation failure of blocks produced by 2.1.x, and in turn caused by
incorrect conversion between packed_transaction_v0 and packed_transaction_v1.
The solution is to make sure a conversion does not stripped any data.
New test cases are added.
Change Type
Select ONE:
Testing Changes
Select ANY that apply:
Consensus Changes
API Changes
Documentation Additions