This repository was archived by the owner on Aug 2, 2022. It is now read-only.
use p2p address for duplicate connection resolution - #10006
Merged
Merged
Conversation
brianjohnson5972
approved these changes
Feb 8, 2021
brianjohnson5972
left a comment
Contributor
There was a problem hiding this comment.
Just add that one comment and it is good.
| } | ||
| else if (my_impl->p2p_address < msg.p2p_address) { | ||
| continue; | ||
| } |
Contributor
There was a problem hiding this comment.
I'd like a comment like "only the p2p node with the higher of the 2 addresses will decide which connection is a duplicate, so there is no chance for both connections to be closed"
huangminghuang
force-pushed
the
huangminghuang/duplicate-connection-fix
branch
from
February 9, 2021 14:36
c41e28e to
614b928
Compare
brianjohnson5972
approved these changes
Feb 9, 2021
huangminghuang
force-pushed
the
huangminghuang/duplicate-connection-fix
branch
from
February 10, 2021 16:40
2102b1a to
d3faf27
Compare
This was referenced Oct 4, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Description
This PR fixes the problem where two nodeos establish p2p connections to each other, send go away messages to each other at the same time and then both connections are dropped without any retry.
Change Type
Select ONE:
Testing Changes
Select ANY that apply:
Consensus Changes
API Changes
Documentation Additions