Skip to content

Reimplement chainbase using intrusive instead of multi_index - #58

Merged
swatanabe-b1 merged 67 commits into
masterfrom
undo_index
Nov 5, 2019
Merged

swatanabe-b1 merged 67 commits into
masterfrom
undo_index

Conversation

@swatanabe-b1

Copy link
Copy Markdown

Primary Features:

  • Per container memory pools
  • full exception safety
  • lighter weight representation of the undo stack.
  • avl trees instead of rb trees.

@arhag arhag left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still need to finish reviewing undo_index.hpp.

Comment thread CMakeLists.txt
Comment thread include/chainbase/chainbase_node_allocator.hpp Outdated
Comment thread include/chainbase/chainbase_node_allocator.hpp
Comment thread include/chainbase/undo_index.hpp
Comment thread include/chainbase/undo_index.hpp
Comment thread include/chainbase/undo_index.hpp
Comment thread include/chainbase/shared_cow_string.hpp
Comment thread include/chainbase/undo_index.hpp Outdated

@arhag arhag left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More reviewing left to do on undo_index.hpp. I just wanted to get the pending comments out earlier.

Comment thread include/chainbase/undo_index.hpp Outdated
Comment thread include/chainbase/undo_index.hpp Outdated
Comment thread include/chainbase/undo_index.hpp
Comment thread include/chainbase/undo_index.hpp Outdated
Comment thread include/chainbase/undo_index.hpp Outdated
Comment thread include/chainbase/undo_index.hpp Outdated
Comment thread include/chainbase/undo_index.hpp Outdated
Comment thread include/chainbase/undo_index.hpp Outdated
Comment thread include/chainbase/undo_index.hpp Outdated
Comment thread include/chainbase/undo_index.hpp Outdated
Comment thread include/chainbase/undo_index.hpp Outdated
Comment thread include/chainbase/undo_index.hpp Outdated
Comment thread include/chainbase/undo_index.hpp
Comment thread include/chainbase/undo_index.hpp
Comment thread include/chainbase/undo_index.hpp Outdated
@swatanabe-b1
swatanabe-b1 merged commit 100f76d into master Nov 5, 2019
@swatanabe-b1
swatanabe-b1 deleted the undo_index branch November 5, 2019 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants