Integrate ShareMeNot functionality - #196

This is awesome, thanks so much! Can you show me an example of a page where it messes with the layout? I will have to do some testing and if it does mess up the layout as you say I will want to make an options page for privacy badger before I merge this pull request.

Hmm, I can't find a great example at the moment. Here's a page where the replacement buttons look weird (scroll to the bottom), but I just realized they look a little weird normally as well: http://www.webmonkey.com/2010/04/adding-facebook-like-buttons-to-your-site-is-damn-easy/. I do occasionally get complaints from ShareMeNot users.

It looks like that site is wonky with or without ShareMeNot, I will keep
testing and see if I can find any other weird behavior. One thing I
noticed is that the webmonkey page seems to have links to share on digg
and stumble upon that don't get replaced. Is that the expected behavior
or a bug?

• Cooper

On 06/09/2014 10:10 PM, Franzi Roesner wrote:

Hmm, I can't find a great example at the moment. Here's a page where the
replacement buttons look weird (scroll to the bottom), but I just
realized they look a little weird normally as well:
http://www.webmonkey.com/2010/04/adding-facebook-like-buttons-to-your-site-is-damn-easy/.
I do occasionally get complaints from ShareMeNot users.

—
Reply to this email directly or view it on GitHub
#196 (comment).

I think those buttons don't involve third-party requests, just local css,
so there's actually nothing to block. However, it can be the case that
ShareMeNot will sometimes miss unfamiliar versions of buttons (i.e.,
buttons not represented in socialwidgets.json). If the requests for those
buttons are blocked by Privacy Badger, the buttons should just be missing,
though.

On Tue, Jun 10, 2014 at 11:53 AM, Cooper Quintin [email protected]
wrote:

It looks like that site is wonky with or without ShareMeNot, I will keep
testing and see if I can find any other weird behavior. One thing I
noticed is that the webmonkey page seems to have links to share on digg
and stumble upon that don't get replaced. Is that the expected behavior
or a bug?

• Cooper

On 06/09/2014 10:10 PM, Franzi Roesner wrote:

Hmm, I can't find a great example at the moment. Here's a page where the
replacement buttons look weird (scroll to the bottom), but I just
realized they look a little weird normally as well:

http://www.webmonkey.com/2010/04/adding-facebook-like-buttons-to-your-site-is-damn-easy/
.
I do occasionally get complaints from ShareMeNot users.

—
Reply to this email directly or view it on GitHub
<
#196 (comment)
.

—
Reply to this email directly or view it on GitHub
#196 (comment)
.

Cool, that makes sense. This looks fine so far in my testing. I will add an option to turn it off when I make an options page for privacy badger.