Skip to content

Mismatch between DNR and what we think happened for PSL domains #3175

Description

@ghostwords

There is a mismatch between DNR and our reporting that happens when we have (what is now) a PSL domain set to "block" in seed data and we encounter a eTLD+1 of that PSL in the wild.

  • MV3/DNR PB blocks it because DNR requestDomains entries implicitly include subdomains, and requestDomains doesn't care about the PSL list.

  • webRequest doesn't block it (MV2) and doesn't report it as blocked (MV2 and MV3) because getBestAction() does care about the PSL list.

For example: awsapprunner.com on https://helldive.live/weapons

DNR blocks utm7j5pjvi.us-east-1.awsapprunner.com. We do not block/report as blocked because there is no snitch_map entry for utm7j5pjvi.us-east-1.awsapprunner.com and we don't look at awsapprunner.com the same way we don't look whether we learned to block com or co.uk.

Another example: various PSL domains that end with on.aws (first undo 0731951), for example on https://maximum-pain.com/stacked

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    MV3Manifest V3-specific issuebug

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions