Skip to content

fix: verify gateway TLS certificates in SSH examples - #126

Merged
kvinwang merged 1 commit into
Dstack-TEE:mainfrom
phala-agent:fix/ssh-tls-verification
Sep 15, 2026
Merged

kvinwang merged 1 commit into
Dstack-TEE:mainfrom
phala-agent:fix/ssh-tls-verification

Conversation

@phala-agent

Copy link
Copy Markdown
Contributor

Summary

  • Make all three SSH openssl s_client examples fail closed on certificate verification errors.
  • Explicitly set SNI and verify the full app-port gateway hostname, preserving the existing routing and SSH configuration.

Verification

  • git diff --check and bash -n dev.sh passed.
  • Parsed both documented SSH configurations with ssh -G; shell syntax checked all three ProxyCommands after placeholder substitution.
  • Temporary local TLS checks against the extracted commands: 9 passed (trusted matching certificate accepted; untrusted certificate and trusted wrong-host certificate rejected before SSH banner delivery). Full hostname SNI verified in every case. OpenSSL 3.5.7.
  • Ran ./dev.sh check-all: Docker Compose validation unavailable because this environment lacks the Compose subcommand; shellcheck/yamllint skipped because unavailable. The script also reports existing example security warnings and exits zero despite validation errors.

Only the two README files change. Temporary verification artifacts stay outside the repository. Live CVM connections and LibreSSL were not tested.

@kvinwang
kvinwang merged commit 10a4a73 into Dstack-TEE:main Sep 15, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants