Split debug - #233
Merged
Merged
Split debug#233
Conversation
Contributor
Contributor
|
🔧 Report generated by pr-comment-scanbuild |
Add build steps to store split debug information for release builds
r1viollet
force-pushed
the
r1viollet/split_debug
branch
2 times, most recently
from
July 1, 2025 10:06
108ded7 to
31687e2
Compare
- Refactor split debug tasks out of the build - Check if tooling is available to perform split debug operations
r1viollet
force-pushed
the
r1viollet/split_debug
branch
3 times, most recently
from
July 1, 2025 13:32
a09b7fc to
a882f05
Compare
r1viollet
commented
Jul 1, 2025
|
|
||
| ### Build Options | ||
| - **Skip debug extraction**: `./gradlew buildRelease -Pskip-debug-extraction=true` | ||
| - **Debug extraction requires**: `objcopy` (Linux) or `dsymutil` (macOS) |
Contributor
Author
There was a problem hiding this comment.
I did not test on MacOS 😬
Feedback appreciated if this fails
r1viollet
force-pushed
the
r1viollet/split_debug
branch
from
July 1, 2025 14:01
a882f05 to
c4dd50e
Compare
r1viollet
marked this pull request as ready for review
July 1, 2025 14:25
jbachorik
reviewed
Jul 2, 2025
…ler into r1viollet/split_debug
r1viollet
force-pushed
the
r1viollet/split_debug
branch
from
July 2, 2025 13:18
ab25d6a to
35ec2cd
Compare
jbachorik
approved these changes
Jul 2, 2025
zhengyu123
pushed a commit
that referenced
this pull request
Jul 9, 2025
* Split debug Add build steps to store split debug information for release builds
zhengyu123
added a commit
that referenced
this pull request
Jul 9, 2025
* Potential memory leak with the JVMTI wallclock sampler * v1 * Don't sample terminated thread * v2 * v3 * v4 * Safe access * Fix thread state * v5 * Cleanup * Cleanup * safeFetch impl * jdk11 support * v6 * enhance and cleanup * fix nullptr deference * More cleanup * Erwan's finding * Fixed memory leak found by Erwan * [Automated] Bump dev version to 1.29.0 * Update the sonatype repos (#235) * Fix artifact download URL * Split debug (#233) * Split debug Add build steps to store split debug information for release builds * Add the micro-benchmark for thread filtering (#237) * Add the micro-benchmark for thread filtering * Do not test for obviously invalid thread id * Relax threadfilter mem order * Flaky test - j9 OSR (#239) Skip zing and j9 flaky tests * Fix flaky allocation test (#241) Lower threshold for allocation test * jbachorik's comments * More jbachorik's comments * Cleanup thread local references --------- Co-authored-by: zhengyu.gu <[email protected]> Co-authored-by: Datadog Java Profiler <[email protected]> Co-authored-by: Jaroslav Bachorik <[email protected]> Co-authored-by: Jaroslav Bachorik <[email protected]> Co-authored-by: r1viollet <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?:
Add build steps to store split debug information for release builds
Motivation:
Additional Notes:
How to test the change?:
For Datadog employees:
credentials of any kind, I've requested a review from
@DataDog/security-design-and-guidance.Unsure? Have a question? Request a review!