Skip to content

Fix GitLab codeowners exclusion handling - #12021

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
masterfrom
daniel.mohedano/gitlab-codeowners-fix
Jul 22, 2026
Merged

Fix GitLab codeowners exclusion handling#12021
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
masterfrom
daniel.mohedano/gitlab-codeowners-fix

Conversation

@daniel-mohedano

@daniel-mohedano daniel-mohedano commented Jul 21, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

What Does This Do

Fix GitLab CODEOWNERS exclusion parsing. Exclusion patterns now suppress ownership only within their section and do not inherit default owners.

Motivation

GitLab patterns such as !generate/ were treated as inverse matchers. This assigned owners to unrelated paths and failed to exclude matching paths.

Additional Notes

test-environment-trigger: skip

Contributor Checklist

Jira ticket: [PROJ-IDENT]

@daniel-mohedano daniel-mohedano added type: bug fix Bug fix comp: ci visibility Continuous Integration Visibility labels Jul 21, 2026
@daniel-mohedano daniel-mohedano changed the title Improve GitLab codeowners exclusion handling Fix GitLab codeowners exclusion handling Jul 21, 2026
@datadog-official

datadog-official Bot commented Jul 21, 2026 •
edited by datadog-prod-us1-4 Bot
Loading

Copy link
Copy Markdown
Contributor

🎯 Code Coverage (details)
• Patch Coverage: 100.00%
• Overall Coverage: 57.27% (-0.02%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 965481a | Docs | Datadog PR Page | Give us feedback!

@dd-octo-sts

dd-octo-sts Bot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

🟢 Java Benchmark SLOs — All performance SLOs passed

Suite Status
Startup 🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results
Scenario Candidate master Δ (95% CI of mean)
startup:insecure-bank:iast:Agent 13.94 s 13.97 s [-0.9%; +0.5%] (no difference)
startup:insecure-bank:tracing:Agent 12.91 s 13.00 s [-1.5%; +0.0%] (no difference)
startup:petclinic:appsec:Agent 16.88 s 16.68 s [+0.2%; +2.1%] (maybe worse)
startup:petclinic:iast:Agent 16.30 s 16.92 s [-7.9%; +0.6%] (no difference)
startup:petclinic:profiling:Agent 16.65 s 16.82 s [-2.1%; +0.2%] (no difference)
startup:petclinic:sca:Agent 16.90 s 16.81 s [-0.2%; +1.3%] (no difference)
startup:petclinic:tracing:Agent 15.99 s 16.15 s [-1.9%; -0.1%] (maybe better)

Commit: 965481af · CI Pipeline · Benchmarking Platform UI

Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

@daniel-mohedano
daniel-mohedano marked this pull request as ready for review July 21, 2026 13:51
@daniel-mohedano
daniel-mohedano requested a review from a team as a code owner July 21, 2026 13:51
datadog-official[bot]
datadog-official Bot reviewed Jul 21, 2026
View reviewed changes

@datadog-official datadog-official Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Datadog Autotest: PASS

More details

The PR correctly fixes GitLab CODEOWNERS exclusion parsing by moving exclusions from inverse-matcher logic to section-scoped suppression. Exclusions now properly prevent ownership from their section while allowing other sections to claim the same path, matching GitLab semantics. The implementation separates exclusions into a dedicated collection, checks them before ownership entries, and prevents exclusions from inheriting section defaults — all correct. No regressions or edge cases identified.

Was this helpful? React 👍 or 👎

📊 Validated against 6 scenarios · Open Bits AI session

🤖 Datadog Autotest · Commit 965481a · What is Autotest? · Any feedback? Reach out in #autotest

@daniel-mohedano

daniel-mohedano commented Jul 22, 2026

Copy link
Copy Markdown
Contributor Author

/merge

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented Jul 22, 2026 •
edited
Loading

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-07-22 10:21:08 UTC ℹ️ Start processing command /merge

2026-07-22 10:21:13 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 1h (p90).

2026-07-22 11:16:49 UTC ℹ️ MergeQueue: This merge request was merged

@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot merged commit c341840 into master Jul 22, 2026
601 of 606 checks passed
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot deleted the daniel.mohedano/gitlab-codeowners-fix branch July 22, 2026 11:16
@github-actions github-actions Bot added this to the 1.65.0 milestone Jul 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@datadog-official datadog-official[bot] datadog-official[bot] left review comments
@juan-fernandez juan-fernandez juan-fernandez approved these changes

Assignees

No one assigned

Labels

comp: ci visibility Continuous Integration Visibility type: bug fix Bug fix

Projects

None yet

Milestone

1.65.0

Development

Successfully merging this pull request may close these issues.

2 participants

@daniel-mohedano @juan-fernandez