Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
abdishakoor-dev
left a comment
There was a problem hiding this comment.
Nearly there. The thought experiment in 4-random.js with 60 to 70 is a really clear way to explain it, and spotting in 3-to-pounds.js that the padEnd can never take effect is a good catch.
Three things to sort before I mark this Complete:
- Function calls.
1-percentage-change.jsa) counts four and2-time-format.jsb) says none. Both files have one more on line 10. See the comments on lines 18 and 22. 2-mandatory-errors/1.js,2.jsand4.jsexplain the fix but never say what the error was. The task asks you to run the original, read the error node prints, and explain it. You did exactly that in3.js, which is the model. Put the original back for a moment in each of the other three, run it, and write the message and the reason above your fix.- Formatting. Prettier fails on eight of the files. Same as you did for Form Controls: open each file in Sprint-2, right click, Format Document, save and commit. Turning on format on save would do it for you from now on.
Add the Needs Review label again once you've pushed.
|
|
||
| // a) How many function calls are there in this file? Write down all the lines where a function call is made | ||
|
|
||
| // 4 function calls are made. |
There was a problem hiding this comment.
Four on lines 4 and 5 is right. What is console.log(...) on line 10?
There was a problem hiding this comment.
Five, yes. console.log is the easy one to miss.
|
|
||
| // b) How many function calls are there? | ||
|
|
||
| // 0 |
There was a problem hiding this comment.
Same question as in the other file: what is console.log(result) on line 10?
| let age = 33; | ||
| age = age + 1; | ||
|
|
||
| // Answer: I changed the const to let, so the variable age becomes reassignable |
There was a problem hiding this comment.
The fix is right. Change it back to const for a moment and run the file. What does node print, word for word, and what is it about const that causes it? That's the part the exercise is after, like you did in 3.js.
There was a problem hiding this comment.
That's the message, and you've done the same in 2.js and 4.js.
| const dir = ; | ||
| const ext = ; | ||
| const dir = filePath.slice(0,lastSlashIndex); | ||
| console.log(`The dir parth of ${filePath} is ${dir}`); |
There was a problem hiding this comment.
Not a blocker: "parth".
abdishakoor-dev
left a comment
There was a problem hiding this comment.
All fixed, marking this as complete, well done
Learners, PR Template
Self checklist
Task code
CYF-1039
Changelist
I answered questions and solved error issues in the files in folders 1, 2, 3 and 4, in order.