Cape Town | 25-ITP-MAY | Asanda Dunn | Sprint 1 | Form Controls - #1524
Open
asandagwala wants to merge 3 commits into
Open
asandagwala wants to merge 3 commits into
asandagwala wants to merge 3 commits into
Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
cjyuan
reviewed
Sep 17, 2026
cjyuan
left a comment
Contributor
There was a problem hiding this comment.
- Could you improve the Lighthouse Accessibility score to 100?
- Currently, the user could submit the form without filling in all input. Could you fix the issue?
Comment on lines
+29
to
+39
| <div> | ||
| <p>Colour</p> | ||
| <input type ="radio" name = "colour" id = "red" value = "Red" required /> | ||
| <label for = "red">Red</label> | ||
|
|
||
| <input type = "radio" name = "colour" id = "blue" value = "Blue"/> | ||
| <label for = "blue">Blue</label> | ||
|
|
||
| <input type = "radio" name = "colour" id = "black" value = "Black"/> | ||
| <label for = "black">Black</label> | ||
| </div> |
Contributor
There was a problem hiding this comment.
Indentation and spacing aree not fully consistent.
Suggestion:
- Look up the benefits of using a code formatter.
- Install the Prettier extension for VS Code, then:
- Use VS Code's Format Document feature to format your code.
- Optionally, enable Format On Save and Format On Paste to keep your code consistently formatted.
Resource: Visual Studio Code - Formatting
Note: The formatter may not work correctly if your code contains syntax errors.
Contributor
|
In your PR description,
Could you refer to some of these completed PRs to see how the PR description should look like, and then update your PR description accordingly? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task ID: CYF-1004
PR Description