Conversation
Use known MacFUSE compiler and linker options instead of pkg-config when building with NOPKGCONFIG. An official build should compile with MacFUSE to make sure the application will work regardless of whether an end-user's system is using MacFUSE or its successor OSXFUSE (with MacFUSE compatibility). Not using pkg-config also has the advantage of not having to install pkg-config (through e.g. MacPorts, Fink, or Homebrew) which makes it easier to do a build on an offline system.
|
still reviewing, it seems to be the opposite of another patch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use known MacFUSE compiler and linker options instead of pkg-config when
building with NOPKGCONFIG. An official build should compile with MacFUSE
to make sure the application will work regardless of whether an end-user's
system is using MacFUSE or its successor OSXFUSE (with MacFUSE
compatibility).
Not using pkg-config also has the advantage of not having to install
pkg-config (through e.g. MacPorts, Fink, or Homebrew) which makes it
easier to do a build on an offline system.